Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit a patch for a defect which file link jump fails in GitX (L) #207

Open
johnnytemp opened this issue Sep 7, 2012 · 2 comments
Open

Comments

@johnnytemp
Copy link

Dear laullon,

I found and fixed a small bug in GitX (L) that "file link" in changes-of-a-commit view cannot jump, in case if a file's path has "b/" pattern.

See whether you would like to apply it to your project.

Here is it:

line 464 of file /GLFileView.m, based on commit : 23c99a7

--- 464 NSRange b = [line rangeOfString:@"b/"];
+++ 464 NSRange b = [line rangeOfString:@" b/"]; // Fixed @"b/" to @" b/"

Sorry for my disturbance.

Yours sincerely,
Johnny Wong.

@johnnytemp
Copy link
Author

To make it clear, for example: your project folder is named "xxb", when you view any commit histories which contains changes for some files inside folder "xxb", clicking on the hyper-link of those files cannot jump to the corresponding change.

Johnny

@jasonkarns
Copy link

👍 This 🐛 has been bugging me for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants