Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses of \@tempa in \Ref #1579

Open
muzimuzhi opened this issue Dec 9, 2024 · 1 comment
Open

Uses of \@tempa in \Ref #1579

muzimuzhi opened this issue Dec 9, 2024 · 1 comment
Labels
category base (latex) enhancement fixed in dev Fixed in development branch, not in stable release

Comments

@muzimuzhi
Copy link
Contributor

Brief outline of the enhancement

\Ref is the only kernel macro which uses \@tempa. It's ok when \Ref was provided by varioref package, but when it's moved to the kernel, maybe \@tempa can be replaced with \reserved@a.

latex2e/base/ltxref.dtx

Lines 549 to 557 in 803ec3b

% \changes{v1.1l}{2019/08/22}{Commanded moved from \texttt{varioref.sty}}
% \changes{v1.1p}{2022/04/12}{Macro reimplemented with a starred version}%
% \begin{macrocode}
\def\@kernel@Ref#1{\protected@edef\@tempa{\@kernel@ref{#1}}%
\expandafter\MakeUppercase\@tempa}
\def\@kernel@sRef#1{\protected@edef\@tempa{\@kernel@sref{#1}}%
\expandafter\MakeUppercase\@tempa}
\NewDocumentCommand\Ref{s}
{\IfBooleanTF{#1}{\@kernel@sRef}{\@kernel@Ref}}

What to do about its rollback codes?

@FrankMittelbach
Copy link
Member

yes we could/should change that (don't think it warrants rollback, though - I think we can just alter the 2022 code). Otherwise it would mean splitting the rollback into chunks which is painful and not really that helpful in this case.

muzimuzhi added a commit to muzimuzhi/latex2e that referenced this issue Dec 9, 2024
muzimuzhi added a commit to muzimuzhi/latex2e that referenced this issue Dec 9, 2024
FrankMittelbach pushed a commit that referenced this issue Dec 10, 2024
@FrankMittelbach FrankMittelbach added enhancement category base (latex) fixed in dev Fixed in development branch, not in stable release labels Jan 14, 2025
@github-project-automation github-project-automation bot moved this to Pool (unscheduled issues) in upcoming LaTeX2e releases Jan 14, 2025
@FrankMittelbach FrankMittelbach moved this from Pool (unscheduled issues) to Done in dev in upcoming LaTeX2e releases Jan 14, 2025
@FrankMittelbach FrankMittelbach added this to the Release 2025 Spring milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category base (latex) enhancement fixed in dev Fixed in development branch, not in stable release
Projects
Status: Done in dev
Development

No branches or pull requests

2 participants