lscapeenhanced

[Rimole]

There is: #166
And there is: https://www.ctan.org/pkg/lscapeenhanced

lscapeenhanced seems to fix the bug without breaking anything. (Does it?)

Would it be possible to merge lscapeenhanced into lscape?

[u-fischer]

lscapeenhanced seems to fix the bug without breaking anything

Didn't you read the documentation? lscapeenhanced doesn't "fix" #166. \textheight is still (as with lscape) unchanged. But it additionally also leaves \textheight unchanged. Personally I doubt that users really want that:

\documentclass{article}
\usepackage{lscapeenhanced}
\begin{document}
\SetKeys[lscapeenhanced]{lscape=false}
\begin{landscape}
\noindent\rule{\linewidth}{\textheight}
\end{landscape}

\begin{landscape}
\noindent\rule{\textwidth}{\textheight}
\end{landscape}

\SetKeys[lscapeenhanced]{lscape=true}
\begin{landscape}
\noindent\rule{\textwidth}{\textheight}
\end{landscape}

\begin{landscape}
\noindent\rule{\linewidth}{\textheight}
\end{landscape}

\end{document}

The first two pages are the original, the following four pages with the lscapeenhanced patch:

[Rimole]

So: "it depends". For the code below, I need \usepackage{lscapeenhanced}, otherwise "TEXT" is placed at the wrong place.
But because of the "it depends", it makes sense to not merge it.

\documentclass{article}
\usepackage{lscape}
\usepackage{lscapeenhanced}
\usepackage{atbegshi}
\AddToHook{shipout/before}{\AtBeginShipoutUpperLeft{%
\put(0sp,-\dimexpr 1in+\voffset+\topmargin+\headheight+\headsep+\footskip+\textheight\relax){TEXT}%
}}
\begin{document}
\begin{landscape}
landscape
\end{landscape}
\end{document}