feat: Expand JSON utils with TransactionResult classes and extrinsic_identifier

- Add TransactionResult and MultiTransactionResult classes for consistent
  transaction responses across all commands
- Add print_transaction_response() helper function
- Update schema to use {success, message, extrinsic_identifier} format
- Migrate wallets.py: transfer, swap_hotkey, set_id
- Migrate sudo.py: trim command
- Migrate stake/add.py and stake/remove.py
- Migrate liquidity.py: add_liquidity, remove_liquidity, modify_liquidity
- Update tests for new transaction response utilities (25 tests passing)

This addresses feedback from @thewhaleking on PR #781 to apply standardized
JSON output to all json_console usages with extrinsic_identifier support.

Closes #635

Author: DanielDerefaka

bittensor_cli/src/bittensor/json_utils.py

@@ -4,35 +4,138 @@
 This module provides consistent JSON response formatting across all btcli commands.
 All JSON outputs should use these utilities to ensure schema compliance.
 
-Standard Response Format:
+Standard Transaction Response Format:
 {
-    "success": bool,       # Required: Whether the operation succeeded
-    "data": {...},         # Optional: Command-specific response data
-    "error": str           # Optional: Error message if success=False
+    "success": bool,                    # Required: Whether the operation succeeded
+    "message": str | None,              # Optional: Human-readable message
+    "extrinsic_identifier": str | None  # Optional: Block-extrinsic ID (e.g., "12345-2")
 }
 
-For transaction responses, data should include:
+Standard Data Response Format:
 {
-    "extrinsic_hash": str,  # The transaction hash
-    "block_hash": str       # The block containing the transaction
+    "success": bool,       # Required: Whether the operation succeeded
+    "data": {...},         # Optional: Command-specific response data
+    "error": str           # Optional: Error message if success=False
 }
 """
 
 import json
 from typing import Any, Optional, Union
 from rich.console import Console
 
-# JSON console for outputting JSON responses
 json_console = Console()
 
 
+def transaction_response(
+    success: bool,
+    message: Optional[str] = None,
+    extrinsic_identifier: Optional[str] = None,
+) -> dict[str, Any]:
+    """
+    Create a standardized transaction response dictionary.
+
+    Args:
+        success: Whether the transaction succeeded
+        message: Human-readable status message
+        extrinsic_identifier: The extrinsic ID (e.g., "12345678-2")
+
+    Returns:
+        Dictionary with standardized transaction format
+    """
+    return {
+        "success": success,
+        "message": message,
+        "extrinsic_identifier": extrinsic_identifier,
+    }
+
+
+def print_transaction_response(
+    success: bool,
+    message: Optional[str] = None,
+    extrinsic_identifier: Optional[str] = None,
+) -> None:
+    """
+    Print a standardized transaction response as JSON.
+
+    Args:
+        success: Whether the transaction succeeded
+        message: Human-readable status message
+        extrinsic_identifier: The extrinsic ID (e.g., "12345678-2")
+    """
+    json_console.print_json(data=transaction_response(success, message, extrinsic_identifier))
+
+
+class TransactionResult:
+    """
+    Helper class for building transaction responses.
+
+    Provides a clean interface for transaction commands that need to
+    build up response data before printing.
+    """
+
+    def __init__(
+        self,
+        success: bool,
+        message: Optional[str] = None,
+        extrinsic_identifier: Optional[str] = None,
+    ):
+        self.success = success
+        self.message = message
+        self.extrinsic_identifier = extrinsic_identifier
+
+    def as_dict(self) -> dict[str, Any]:
+        """Return the response as a dictionary."""
+        return transaction_response(
+            self.success,
+            self.message,
+            self.extrinsic_identifier,
+        )
+
+    def print(self) -> None:
+        """Print the response as JSON."""
+        json_console.print_json(data=self.as_dict())
+
+
+class MultiTransactionResult:
+    """
+    Helper class for commands that process multiple transactions.
+
+    Builds a keyed dictionary of transaction results.
+    """
+
+    def __init__(self):
+        self._results: dict[str, TransactionResult] = {}
+
+    def add(
+        self,
+        key: str,
+        success: bool,
+        message: Optional[str] = None,
+        extrinsic_identifier: Optional[str] = None,
+    ) -> None:
+        """Add a transaction result with the given key."""
+        self._results[key] = TransactionResult(success, message, extrinsic_identifier)
+
+    def add_result(self, key: str, result: TransactionResult) -> None:
+        """Add an existing TransactionResult with the given key."""
+        self._results[key] = result
+
+    def as_dict(self) -> dict[str, dict[str, Any]]:
+        """Return all results as a dictionary."""
+        return {k: v.as_dict() for k, v in self._results.items()}
+
+    def print(self) -> None:
+        """Print all results as JSON."""
+        json_console.print_json(data=self.as_dict())
+
+
 def json_response(
     success: bool,
     data: Optional[Any] = None,
     error: Optional[str] = None,
 ) -> str:
     """
-    Create a standardized JSON response string.
+    Create a standardized JSON response string for data queries.
 
     Args:
         success: Whether the operation succeeded
@@ -62,7 +165,7 @@ def json_response(
 
 def json_success(data: Any) -> str:
     """
-    Create a successful JSON response.
+    Create a successful JSON response string.
 
     Args:
         data: Response data to include
@@ -75,7 +178,7 @@ def json_success(data: Any) -> str:
 
 def json_error(error: str, data: Optional[Any] = None) -> str:
     """
-    Create an error JSON response.
+    Create an error JSON response string.
 
     Args:
         error: Error message describing what went wrong
@@ -87,43 +190,9 @@ def json_error(error: str, data: Optional[Any] = None) -> str:
     return json_response(success=False, data=data, error=error)
 
 
-def json_transaction(
-    success: bool,
-    extrinsic_hash: Optional[str] = None,
-    block_hash: Optional[str] = None,
-    error: Optional[str] = None,
-    **extra_data: Any,
-) -> str:
-    """
-    Create a standardized transaction response.
-
-    Args:
-        success: Whether the transaction succeeded
-        extrinsic_hash: The transaction/extrinsic hash
-        block_hash: The block hash containing the transaction
-        error: Error message if transaction failed
-        **extra_data: Additional transaction-specific data
-
-    Returns:
-        JSON string with transaction details
-    """
-    data: dict[str, Any] = {}
-
-    if extrinsic_hash is not None:
-        data["extrinsic_hash"] = extrinsic_hash
-
-    if block_hash is not None:
-        data["block_hash"] = block_hash
-
-    # Add any extra data
-    data.update(extra_data)
-
-    return json_response(success=success, data=data if data else None, error=error)
-
-
 def print_json(response: str) -> None:
     """
-    Print a JSON response to the console.
+    Print a JSON string response to the console.
 
     Args:
         response: JSON string to print
@@ -152,6 +221,16 @@ def print_json_error(error: str, data: Optional[Any] = None) -> None:
     print_json(json_error(error, data))
 
 
+def print_json_data(data: Any) -> None:
+    """
+    Print data directly as JSON (for simple data responses).
+
+    Args:
+        data: Data to print as JSON
+    """
+    json_console.print_json(data=data)
+
+
 def serialize_balance(balance: Any) -> dict[str, Union[int, float]]:
     """
     Serialize a Balance object to a consistent dictionary format.

bittensor_cli/src/commands/liquidity/liquidity.py

@@ -14,6 +14,12 @@
     json_console,
     print_extrinsic_id,
 )
+from bittensor_cli.src.bittensor.json_utils import (
+    print_transaction_response,
+    print_json_data,
+    TransactionResult,
+    MultiTransactionResult,
+)
 from bittensor_cli.src.bittensor.balances import Balance, fixed_to_float
 from bittensor_cli.src.commands.liquidity.utils import (
     LiquidityPosition,
@@ -295,13 +301,7 @@ async def add_liquidity(
     else:
         ext_id = None
     if json_output:
-        json_console.print_json(
-            data={
-                "success": success,
-                "message": message,
-                "extrinsic_identifier": ext_id,
-            }
-        )
+        print_transaction_response(success, message, ext_id)
     else:
         if success:
             console.print(
@@ -558,9 +558,7 @@ async def show_liquidity_list(
     if not json_output:
         console.print(liquidity_table)
     else:
-        json_console.print(
-            json.dumps({"success": True, "err_msg": "", "positions": json_table})
-        )
+        print_json_data({"success": True, "err_msg": "", "positions": json_table})
 
 
 async def remove_liquidity(
@@ -584,9 +582,7 @@ async def remove_liquidity(
         success, msg, positions = await get_liquidity_list(subtensor, wallet, netuid)
         if not success:
             if json_output:
-                json_console.print_json(
-                    data={"success": False, "err_msg": msg, "positions": positions}
-                )
+                print_json_data({"success": False, "err_msg": msg, "positions": positions})
             else:
                 return print_error(f"Error: {msg}")
             return None
@@ -629,14 +625,11 @@ async def remove_liquidity(
             else:
                 print_error(f"Error removing {posid}: {msg}")
     else:
-        json_table = {}
+        json_results = MultiTransactionResult()
         for (success, msg, ext_receipt), posid in zip(results, position_ids):
-            json_table[posid] = {
-                "success": success,
-                "err_msg": msg,
-                "extrinsic_identifier": await ext_receipt.get_extrinsic_identifier(),
-            }
-        json_console.print_json(data=json_table)
+            ext_id = await ext_receipt.get_extrinsic_identifier() if ext_receipt else None
+            json_results.add(str(posid), success, msg, ext_id)
+        json_results.print()
     return None
 
 
@@ -657,7 +650,7 @@ async def modify_liquidity(
     if not await subtensor.subnet_exists(netuid=netuid):
         err_msg = f"Subnet with netuid: {netuid} does not exist in {subtensor}."
         if json_output:
-            json_console.print(json.dumps({"success": False, "err_msg": err_msg}))
+            print_transaction_response(False, err_msg, None)
         else:
             print_error(err_msg)
         return False
@@ -687,9 +680,7 @@ async def modify_liquidity(
     )
     if json_output:
         ext_id = await ext_receipt.get_extrinsic_identifier() if success else None
-        json_console.print_json(
-            data={"success": success, "err_msg": msg, "extrinsic_identifier": ext_id}
-        )
+        print_transaction_response(success, msg, ext_id)
     else:
         if success:
             await print_extrinsic_id(ext_receipt)

bittensor_cli/src/commands/stake/add.py

@@ -26,6 +26,7 @@
     get_hotkey_pub_ss58,
     print_extrinsic_id,
 )
+from bittensor_cli.src.bittensor.json_utils import print_json_data
 from bittensor_wallet import Wallet
 
 if TYPE_CHECKING:
@@ -528,13 +529,11 @@ async def stake_extrinsic(
                     staking_address
                 ] = await ext_receipt.get_extrinsic_identifier()
     if json_output:
-        json_console.print_json(
-            data={
-                "staking_success": successes,
-                "error_messages": error_messages,
-                "extrinsic_ids": extrinsic_ids,
-            }
-        )
+        print_json_data({
+            "staking_success": successes,
+            "error_messages": error_messages,
+            "extrinsic_ids": extrinsic_ids,
+        })
 
 
 # Helper functions

bittensor_cli/src/commands/stake/remove.py

@@ -29,6 +29,7 @@
     get_hotkey_pub_ss58,
     print_extrinsic_id,
 )
+from bittensor_cli.src.bittensor.json_utils import print_json_data
 
 if TYPE_CHECKING:
     from bittensor_cli.src.bittensor.subtensor_interface import SubtensorInterface
@@ -370,7 +371,7 @@ async def unstake(
         f"[{COLOR_PALETTE['STAKE']['STAKE_AMOUNT']}]Unstaking operations completed."
     )
     if json_output:
-        json_console.print_json(data=successes)
+        print_json_data(successes)
     return True
 
 
@@ -580,7 +581,7 @@ async def unstake_all(
                 "extrinsic_identifier": ext_id,
             }
     if json_output:
-        json_console.print(json.dumps({"success": successes}))
+        print_json_data({"success": successes})
 
 
 # Extrinsics