Merge pull request #565 from latchbio/ayush/moar-fix

various fixes

Author: ayushkamat

CHANGELOG.md

@@ -16,6 +16,17 @@ Types of changes
 
 # Latch SDK Changelog
 
+## 2.67.1 - 2025-08-25
+
+### Added
+
+* `latch dockerfile` now has two new options, `--output` and `--config-path` for choosing where to write the output Dockerfile and where to read/write the `.latch/config` used to generate the dockerfile
+* `latch nextflow generate-entrypoint` option `--destination` is now named `--output`
+
+### Changes
+
+* `latch dockerfile` now generates a `.dockerignore` always without asking for confirmation.
+
 ## 2.67.0 - 2025-08-21
 
 ### Added

pyproject.toml

@@ -12,7 +12,7 @@ include = ["src/**/*.py", "src/**/py.typed", "src/latch_cli/services/init/*"]
 
 [project]
 name = "latch"
-version = "2.67.0"
+version = "2.67.1"
 description = "The Latch SDK"
 authors = [{ name = "Kenny Workman", email = "[email protected]" }]
 maintainers = [{ name = "Ayush Kamat", email = "[email protected]" }]

src/latch_cli/constants.py

@@ -5,7 +5,7 @@
 
 class Units(int, Enum):
     KiB = 2**10
-    kB = 10**3
+    kB = 10**3  # noqa: N815
 
     MiB = 2**20
     MB = 10**6
@@ -22,7 +22,7 @@ class LatchConstants:
     base_image: str = (
         "812206152185.dkr.ecr.us-west-2.amazonaws.com/latch-base:cb01-main"
     )
-    nextflow_latest_version: str = "v2.3.0"
+    nextflow_latest_version: str = "v3.0.5"
 
     file_max_size: int = 4 * Units.MiB
     file_chunk_size: int = 64 * Units.MiB

src/latch_cli/docker_utils/__init__.py

@@ -399,9 +399,8 @@ def generate(self, *, dest: Optional[Path] = None, overwrite: bool = False):
 
 
 def generate_dockerignore(
-    pkg_root: Path, *, wf_type: WorkflowType, overwrite: bool = False
+    dest: Path, *, wf_type: WorkflowType, overwrite: bool = False
 ) -> None:
-    dest = Path(pkg_root) / ".dockerignore"
     if dest.exists():
         if dest.is_dir():
             click.secho(
@@ -415,7 +414,7 @@ def generate_dockerignore(
         ):
             return
 
-    files = [".git", ".github"]
+    files = [".git", ".github", ".venv"]
 
     if wf_type == WorkflowType.nextflow:
         files.extend([".nextflow*", ".nextflow.log*", "work/", "results/"])
@@ -425,11 +424,13 @@ def generate_dockerignore(
     click.secho(f"Successfully generated .dockerignore `{dest}`", fg="green")
 
 
-def get_default_dockerfile(pkg_root: Path, *, wf_type: WorkflowType, overwrite: bool = False):
+def get_default_dockerfile(
+    pkg_root: Path, *, wf_type: WorkflowType, overwrite: bool = False
+):
     default_dockerfile = pkg_root / "Dockerfile"
 
     config = get_or_create_workflow_config(
-        pkg_root=pkg_root,
+        pkg_root / ".latch" / "config",
         base_image_type=BaseImageOptions.nextflow
         if wf_type == WorkflowType.nextflow
         else BaseImageOptions.default,

src/latch_cli/main.py

@@ -239,6 +239,21 @@ def init(
     type=click.Path(exists=True, dir_okay=False, path_type=Path),
     help="Path to a direnv file (.env) containing environment variables to inject into the container.",
 )
+@click.option(
+    "--output",
+    "-o",
+    type=click.Path(path_type=Path),
+    help="Where to write the result Dockerfile. Default is Dockerfile in the root of the workflow directory.",
+)
+@click.option(
+    "--config-path",
+    type=click.Path(path_type=Path),
+    help=(
+        "Where to read the config to use for generating the Dockerfile. If a config is not found either at"
+        " `config_path` or `config_path / .latch / config`, one will be generated at "
+        "`config_path / .latch / config`. If not provided, it will default to the parent of the output Dockerfile"
+    ),
+)
 def dockerfile(
     pkg_root: Path,
     snakemake: bool = False,
@@ -250,8 +265,10 @@ def dockerfile(
     pyproject: Optional[Path] = None,
     pip_requirements: Optional[Path] = None,
     direnv: Optional[Path] = None,
+    output: Optional[Path] = None,
+    config_path: Optional[Path] = None,
 ):
-    """Generates a user editable dockerfile for a workflow and saves under `pkg_root/Dockerfile`.
+    """Generates a user editable dockerfile for a workflow.
 
     Visit docs.latch.bio to learn more.
     """
@@ -275,10 +292,32 @@ def dockerfile(
         workflow_type = WorkflowType.nextflow
         base_image = BaseImageOptions.nextflow
 
-    config = get_or_create_workflow_config(
-        pkg_root=pkg_root, base_image_type=base_image
+    if output is None:
+        output = pkg_root / "Dockerfile"
+    if output.name != "Dockerfile":
+        output /= "Dockerfile"
+
+    ignore_path = output.with_name(".dockerignore")
+
+    if config_path is None:
+        config_path = output.parent / ".latch" / "config"
+    if config_path.name != "config":
+        config_path /= ".latch/config"
+
+    click.secho(
+        dedent(f"""\
+    The following files will be generated:
+    {click.style("Dockerfile:", fg="bright_blue")} {output}
+    {click.style("Ignore File:", fg="bright_blue")} {ignore_path}
+    {click.style("Latch Config:", fg="bright_blue")} {config_path}
+    """)
     )
 
+    output.parent.mkdir(exist_ok=True, parents=True)
+
+    # todo(ayush): make overwriting this easier
+    config = get_or_create_workflow_config(config_path, base_image_type=base_image)
+
     builder = DockerfileBuilder(
         pkg_root,
         wf_type=workflow_type,
@@ -290,12 +329,9 @@ def dockerfile(
         pip_requirements=pip_requirements,
         direnv=direnv,
     )
-    builder.generate(overwrite=force)
+    builder.generate(dest=output, overwrite=force)
 
-    if not click.confirm("Generate a .dockerignore?"):
-        return
-
-    generate_dockerignore(pkg_root, wf_type=workflow_type, overwrite=force)
+    generate_dockerignore(ignore_path, wf_type=workflow_type, overwrite=force)
 
 
 @main.command("generate-metadata")
@@ -1086,8 +1122,8 @@ def version(pkg_root: Path):
     help="Set execution profile for Nextflow workflow",
 )
 @click.option(
-    "--destination",
-    "-d",
+    "--output",
+    "-o",
     type=click.Path(path_type=Path),
     default=None,
     help=(
@@ -1101,7 +1137,7 @@ def generate_entrypoint(
     metadata_root: Optional[Path],
     nf_script: Path,
     execution_profile: Optional[str],
-    destination: Optional[Path],
+    output: Optional[Path],
     yes: bool,
 ):
     """Generate a `wf/entrypoint.py` file from a Nextflow workflow"""
@@ -1110,23 +1146,23 @@ def generate_entrypoint(
     from latch_cli.nextflow.workflow import generate_nextflow_workflow
     from latch_cli.services.register.utils import import_module_by_path
 
-    if destination is None:
-        destination = pkg_root / "wf" / "custom_entrypoint.py"
+    if output is None:
+        output = pkg_root / "wf" / "custom_entrypoint.py"
 
-    destination = destination.with_suffix(".py")
+    output = output.with_suffix(".py")
 
     if not yes and not click.confirm(
-        f"Will generate an entrypoint at {destination}. Proceed?"
+        f"Will generate an entrypoint at {output}. Proceed?"
     ):
         raise click.exceptions.Abort
 
-    destination.parent.mkdir(exist_ok=True)
+    output.parent.mkdir(exist_ok=True)
 
     if (
         not yes
-        and destination.exists()
+        and output.exists()
         and not click.confirm(
-            f"Nextflow entrypoint already exists at `{destination}`. Overwrite?"
+            f"Nextflow entrypoint already exists at `{output}`. Overwrite?"
         )
     ):
         return
@@ -1151,11 +1187,7 @@ def generate_entrypoint(
         raise click.exceptions.Exit(1)
 
     generate_nextflow_workflow(
-        pkg_root,
-        metadata_root,
-        nf_script,
-        destination,
-        execution_profile=execution_profile,
+        pkg_root, metadata_root, nf_script, output, execution_profile=execution_profile
     )
 
 

src/latch_cli/nextflow/parse_schema.py

@@ -2,7 +2,7 @@
 from dataclasses import dataclass
 from pathlib import Path
 from textwrap import indent
-from typing import Generic, Literal, Optional, TypedDict, TypeVar, Union
+from typing import Literal, Optional, TypedDict, Union
 
 import click
 from typing_extensions import NotRequired, TypeAlias
@@ -63,17 +63,33 @@ class NfBooleanType(TypedDict):
     metadata: CommonMetadata
 
 
-EnumT = TypeVar("EnumT", str, int, float)
+class NfStringEnumType(TypedDict):
+    type: Literal["enum"]
+    flavor: Literal["string"]
+    values: list[str]
+    default: NotRequired[str]
+    metadata: CommonMetadata
+
+
+class NfIntegerEnumType(TypedDict):
+    type: Literal["enum"]
+    flavor: Literal["integer"]
+    values: list[int]
+    default: NotRequired[int]
+    metadata: CommonMetadata
 
 
-class NfEnumType(TypedDict, Generic[EnumT]):
+class NfNumberEnumType(TypedDict):
     type: Literal["enum"]
-    flavor: Literal["string", "integer", "number"]
-    values: list[EnumT]
-    default: NotRequired[EnumT]
+    flavor: Literal["number"]
+    values: list[float]
+    default: NotRequired[float]
     metadata: CommonMetadata
 
 
+NfEnumType: TypeAlias = Union[NfStringEnumType, NfIntegerEnumType, NfNumberEnumType]
+
+
 class NfArrayType(TypedDict):
     type: Literal["array"]
     default: NotRequired[list]
@@ -106,9 +122,7 @@ class NfBlobType(TypedDict):
     NfStringType,
     NfIntegerType,
     NfFloatType,
-    NfEnumType[str],
-    NfEnumType[float],
-    NfEnumType[int],
+    NfEnumType,
     NfBooleanType,
     NfArrayType,
     NfObjectType,
@@ -261,7 +275,7 @@ def parse_bool(
 
 def parse_enum(
     param_name: str, properties: dict[str, object], required_set: set[str]
-) -> Union[NfEnumType[str], NfEnumType[int], NfEnumType[float]]:
+) -> NfEnumType:
     typ = properties["type"]
     assert "enum" in properties
 
@@ -277,13 +291,37 @@ def parse_enum(
     assert values is not None, "enum parameter must specify a set of `values`"
     assert isinstance(values, list), "`values` must be a list"
 
-    # todo(ayush): fix type errors here
-    return NfEnumType(
+    if typ == "string":
+        assert default is None or isinstance(default, str), "default must be a string"
+
+        return NfStringEnumType(
+            type="enum",
+            flavor="string",
+            values=values,
+            metadata=metadata,
+            **({"default": default} if default is not None else {}),
+        )
+    if typ == "integer":
+        assert default is None or isinstance(default, int), "default must be an integer"
+
+        return NfIntegerEnumType(
+            type="enum",
+            flavor="integer",
+            values=values,
+            metadata=metadata,
+            **({"default": default} if default is not None else {}),
+        )
+
+    assert default is None or isinstance(default, (int, float)), (
+        "default must be a number"
+    )
+
+    return NfNumberEnumType(
         type="enum",
-        flavor=typ,
+        flavor="number",
         values=values,
         metadata=metadata,
-        **({"default": default} if default is not None else {}),
+        **({"default": float(default)} if default is not None else {}),
     )
 
 

src/latch_cli/services/init/init.py

@@ -379,7 +379,9 @@ def init(
 
     template_func(pkg_root)
 
-    config = get_or_create_workflow_config(pkg_root, base_image_type)
+    config = get_or_create_workflow_config(
+        pkg_root / ".latch" / "config", base_image_type
+    )
 
     wf_type = WorkflowType.latchbiosdk
     if chosen_template == "Snakemake Example":

src/latch_cli/workflow_config.py

@@ -31,9 +31,8 @@ class LatchWorkflowConfig:
 
 
 def get_or_create_workflow_config(
-    pkg_root: Path, base_image_type: BaseImageOptions = BaseImageOptions.default
+    config_path: Path, base_image_type: BaseImageOptions = BaseImageOptions.default
 ) -> LatchWorkflowConfig:
-    config_path = pkg_root / latch_constants.pkg_config
     if config_path.exists() and config_path.is_file():
         try:
             return LatchWorkflowConfig(**json.loads(config_path.read_text()))
@@ -60,9 +59,7 @@ def get_or_create_workflow_config(
         date=datetime.now(timezone.utc).isoformat(),
     )
 
-    (pkg_root / ".latch").mkdir(exist_ok=True)
-
-    with (pkg_root / latch_constants.pkg_config).open("w") as f:
-        f.write(json.dumps(asdict(config)))
+    config_path.parent.mkdir(parents=True, exist_ok=True)
+    config_path.write_text(json.dumps(asdict(config)))
 
     return config