FEAT: better error message for AxisCollection.index(name)

this is also Python3.14-proof, while we used to rely on the list.index builtin message, which changed (for the worse IMO) in Python 3.14

Author: gdementen

larray/core/axis.py

@@ -2302,7 +2302,10 @@ def index(self, axis, compatible=False) -> int:
             name = axis
         if name is None:
             raise ValueError(f"{axis!r} is not in collection")
-        return self.names.index(name)
+        try:
+            return self.names.index(name)
+        except ValueError:
+            raise ValueError(f"axis {name!r} is not in collection")
 
     # XXX: we might want to return a new AxisCollection (same question for other inplace operations:
     # append, extend, pop, __delitem__, __setitem__)

larray/tests/test_axiscollection.py

@@ -221,9 +221,9 @@ def test_contains(col):
 
 def test_index(col):
     assert col.index('lipro') == 0
-    with must_raise(ValueError, msg="'nonexisting' is not in list"):
+    with must_raise(ValueError, msg="axis 'nonexisting' is not in collection"):
         col.index('nonexisting')
-        assert col.index(0) == 0
+    assert col.index(0) == 0
     assert col.index(1) == 1
     assert col.index(2) == 2
     assert col.index(-1) == -1
@@ -237,9 +237,9 @@ def test_index(col):
     assert col.index(sex) == 1
     assert col.index(age) == 2
     assert col.index(sex2) == 1
-    with must_raise(ValueError, msg="'geo' is not in list"):
+    with must_raise(ValueError, msg="axis 'geo' is not in collection"):
         col.index(geo)
-    with must_raise(ValueError, msg="'value' is not in list"):
+    with must_raise(ValueError, msg="axis 'value' is not in collection"):
         col.index(value)
 
     # test anonymous axes