Skip to content

Commit cacdfea

Browse files
committed
DOC: update TODO
1 parent c44c09e commit cacdfea

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

larray_editor/arraymodel.py

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,26 @@
1212
format_exception, log_caller)
1313

1414
# TODO before using the widget in other projects:
15+
# * cleanup adapter filters API:
16+
# - get_filter_options works for either larray-style filters and
17+
# hlabel filters but cannot work for both at the same time (what the given
18+
# index means).
19+
# - How does axis filters enter the picture?
20+
# - I think we should go towards get_hlabel_actions(row_idx, col_idx) ->
21+
# some kind of Form definition. On any update of the form values,
22+
# the method corresponding to the part of the form that changed is called.
23+
24+
# The simplest form would be:
25+
# {'filters': (self.change_filters, [label_values]),
26+
# 'sort': (self.change_sort, ...,
27+
# 'group_by: ...}.
28+
# this would also help support custom actions:
29+
# {'Label in menu': callable_to_perform_action | dict for submenu | }
30+
# apply auto gui on it:
31+
# def add_op_from_label(self, sort: ascending|descending|unsorted,
32+
# filter: list_of_labels) -> QuickBarOp:
33+
# ...
34+
#
1535
# * move ndigits/format detection to adapter
1636
# but the trick is to avoid using current column width and just
1737
# target a "reasonable number" of digits
@@ -78,7 +98,6 @@
7898
# superclass or one of their subclasses)
7999

80100
# TODO post release (move to issues):
81-
# * take decoration (sort arrow) into account to compute column widths
82101
# * mouse selection on "edges" should move the buffer
83102
# (it scrolls the internal viewport but does not change the offset)
84103

0 commit comments

Comments
 (0)