Carbon v3 (#299)

driesvints · timacdonald · web-flow · commit 801ec40e7d31 · 2024-02-01T12:48:40.000-06:00
* Carbon v3

* wip

* Fix type

---------

Co-authored-by: Tim MacDonald &lt;hello@timacdonald.me&gt;
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
         "illuminate/support": "^10.34|^11.0",
         "illuminate/view": "^10.34|^11.0",
         "livewire/livewire": "^3.2",
-        "nesbot/carbon": "^2.67"
+        "nesbot/carbon": "^2.67|^3.0"
     },
     "require-dev": {
         "guzzlehttp/guzzle": "^7.7",
diff --git a/src/Recorders/SlowRequests.php b/src/Recorders/SlowRequests.php
@@ -52,7 +52,7 @@ public function record(Carbon $startedAt, Request $request, Response $response):
     {
         if (
             ! $request->route() instanceof Route ||
-            $this->underThreshold($duration = $startedAt->diffInMilliseconds()) ||
+            $this->underThreshold($duration = ((int) $startedAt->diffInMilliseconds())) ||
             ! $this->shouldSample()
         ) {
             return;

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function record(Carbon $startedAt, Request $request, Response $response):`
`52`	`52`	`{`
`53`	`53`	`if (`
`54`	`54`	`! $request->route() instanceof Route \|\|`
`55`		`- $this->underThreshold($duration = $startedAt->diffInMilliseconds()) \|\|`
	`55`	`+ $this->underThreshold($duration = ((int) $startedAt->diffInMilliseconds())) \|\|`
`56`	`56`	`! $this->shouldSample()`
`57`	`57`	`) {`
`58`	`58`	`return;`