Do you think we need a job middleware that can ignore some specific exceptions?

[yankewei]

We have a job middleware named FailOnException, when some specific exceptions are thrown in the job, we can immediately mark the job fail, avoiding the job from being retried.
However, when some exceptions are thrown in a job, I think we do need to handle them, and should mark the job as a success or ignore that exception, so I want to make a PR introducing the IgnoreException middleware.

[macropay-solutions]

A try catch in the handle function of a job is considered old school? We need to scratch our right ear with our left hand?

[yankewei]

I just think handling it this way in every job would seem too verbose, and it would be better if we had a middleware.

[macropay-solutions]

Laravel keeps going on this road of burying logic into the framework and you NEED TO KNOW ALL THE LOGIC to use it. At some point it will blow in our faces....

[henzeb]

Not sure if that is the case, but I see a themed party here. We already had a couple of PR's similar to this, can you tell if those are what you were looking for and if they got in?

[yankewei]

Can you show me the PR link?

[henzeb]

ow wait. we have is laravel has.... that's why we should reference PR's or documentation. #56037, you want to add something that does ignoring exceptions. what would "handle them" do? does it need to be specified or is it simply catching them and marking the job as a success? in both cases I don't think we need such a thing. exceptions that don't need to be retried I get, but ignoring certain exceptions? when would you do that? Exceptions are thrown for a reason.

[yankewei]

In business logic, we sometimes need to check if a user is active. If inactive, we throw a custom exception. The global exception handler catches it and returns an error response to the frontend, redirecting the user to a forbidden page. However, when this logic runs in a queue worker, the job fails but is simply discarded without further action. Yet, it still gets logged in the failed_queued_jobs table, which is unnecessary.