test for firing failure event

Author: themsaid

src/PusherChannel.php

@@ -2,21 +2,30 @@
 
 namespace NotificationChannels\PusherPushNotifications;
 
-use Illuminate\Notifications\Events\NotificationFailed;
-use Illuminate\Notifications\Notification;
 use Pusher;
+use Illuminate\Events\Dispatcher;
+use Illuminate\Notifications\Notification;
+use Illuminate\Notifications\Events\NotificationFailed;
 
 class PusherChannel
 {
-    /** @var Pusher */
+    /**
+     * @var \Pusher
+     */
     protected $pusher;
 
+    /**
+     * @var \Illuminate\Events\Dispatcher
+     */
+    private $events;
+
     /**
      * @param \Pusher $pusher
      */
-    public function __construct(Pusher $pusher)
+    public function __construct(Pusher $pusher, Dispatcher $events)
     {
         $this->pusher = $pusher;
+        $this->events = $events;
     }
 
     /**
@@ -26,7 +35,6 @@ public function __construct(Pusher $pusher)
      * @param \Illuminate\Notifications\Notification $notification
      *
      * @return void
-     * @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
      */
     public function send($notifiable, Notification $notification)
     {
@@ -40,7 +48,9 @@ public function send($notifiable, Notification $notification)
         );
 
         if (! in_array($response['status'], [200, 202])) {
-            event(new NotificationFailed($notifiable, $notification, $response));
+            $this->events->fire(
+                new NotificationFailed($notifiable, $notification, $response)
+            );
         }
     }
 

tests/ChannelTest.php

@@ -2,6 +2,8 @@
 
 namespace NotificationChannels\PusherPushNotifications\Test;
 
+use Illuminate\Events\Dispatcher;
+use Illuminate\Notifications\Events\NotificationFailed;
 use Illuminate\Notifications\Notifiable;
 use NotificationChannels\PusherPushNotifications\PusherChannel;
 use Illuminate\Notifications\Notification;
@@ -16,7 +18,9 @@ public function setUp()
     {
         $this->pusher = Mockery::mock(Pusher::class);
 
-        $this->channel = new PusherChannel($this->pusher);
+        $this->events = Mockery::mock(Dispatcher::class);
+
+        $this->channel = new PusherChannel($this->pusher, $this->events);
 
         $this->notification = new TestNotification;
 
@@ -41,6 +45,20 @@ public function it_can_send_a_notification()
 
         $this->channel->send($this->notifiable, $this->notification);
     }
+
+    /** @test */
+    public function it_fires_failure_event_on_failure()
+    {
+        $message = $this->notification->toPushNotification($this->notifiable);
+
+        $data = $message->toArray();
+
+        $this->pusher->shouldReceive('notify')->with('interest_name', $data, true)->andReturn(['status' => 500]);
+
+        $this->events->shouldReceive('fire')->with(Mockery::type(NotificationFailed::class));
+
+        $this->channel->send($this->notifiable, $this->notification);
+    }
 }
 
 class TestNotifiable