-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory fails on 64 bit windows; and 4k displays #105
Comments
Thank you for reporting these problems. I'll have a look at the HANDLE issue as soon as possible. |
the fix for width was pretty easy; but there's issues still with opening files.. |
it also doesn't do a good job of outputting unicode characters. It outputs '?' This is a sample of some code..
|
eFTE doesn't unfortunately support Unicode. Would be nice if it did, but it's a huge task to make the code Unicode-aware. |
I haven't fully looked, but efte and utf-8 on linux through slang works pretty good as a model.... |
Hmm. I looked more. Yes, I understand, no unicode. And in implementing unicode, I'd want to implement it with like UCS-32 internally; but that doesn't even account for clusters and stuff... I also thought tab-completion worked in the directory screen? (does on my older fte build) |
I have a dirty branch that has the fix for handle - that works when NT is not defined. const string = `format ${"something"}` So then I can strip out some c-centric things and improve object highlighting (maybe) I say my branch is 'dirty' because I've included Wordstar keyboard, but mangled it - I should just copy that to a myfte.config thing... |
Can't simply store handles in an unsigned long, as handles are 64-bit on Win64. A blind fix, as I didn't encounter any actual issues before these changes. Fixes half of #105.
The file find object (s_direct) returns 'int' which is only 32 bit. The HANDLE received from FindFirst etc is a void* which is 64 bit on a 64 bit system...
Also in console.h
#define ConMaxCols 256
should be larger. On a 4k monitor is is easy to exceed 256 characters... not sure how much else this will break. I've increased it to 1024 ATM, although 512 is probably enough.
Related PR should be made soon..
The text was updated successfully, but these errors were encountered: