Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue is missing health probes #134

Closed
Slav4ik opened this issue Jul 28, 2024 · 3 comments
Closed

Queue is missing health probes #134

Slav4ik opened this issue Jul 28, 2024 · 3 comments

Comments

@Slav4ik
Copy link

Slav4ik commented Jul 28, 2024

Our k8s ecosystem requires all deployments (not jobs) to have liveness/readiness/startup probes.

langsmith-queue is missing them.
@langchain-infra
Copy link
Contributor

Hi, I actually have just merged in an update that adds this!

@Slav4ik
Copy link
Author

Slav4ik commented Jul 29, 2024

Thank you very much, I must admit I didnt expect it so fast

It seems that a semicolon is missing in this line
And this config was only changed for subdomain variant and not the default.

@langchain-infra
Copy link
Contributor

Great catch and apologies. That is fixed here: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Slav4ik @langchain-infra