Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lance docs suggest that LanceDataset.take() accepts filters, but these are ignored #3444

Open
pimdh opened this issue Feb 13, 2025 · 0 comments
Open

Lance docs suggest that LanceDataset.take() accepts filters, but these are ignored #3444

pimdh opened this issue Feb 13, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@pimdh
Copy link

pimdh commented Feb 13, 2025

The function LanceDataset.take accepts arbitrary kwargs that the docstring suggests are handled as is done in scanner. However, these kwargs are ignored. Would be helpful to remove the kwargs from the function type.
@wjones127 wjones127 added the good first issue Good for newcomers label Feb 13, 2025
@lyang24 lyang24 mentioned this issue Feb 15, 2025
Merged
BubbleCal added a commit that referenced this issue Feb 28, 2025
@lyang24 @BubbleCal
chore(api)!: remove unused param in take call (#3453)
6756a12 
Related to #3444

Removed unused kwargs parameter in
[LanceDataset.take](https://github.com/lancedb/lance/blob/main/python/python/lance/dataset.py#L791)

---------

Signed-off-by: BubbleCal <[email protected]>
Co-authored-by: BubbleCal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pimdh @wjones127