Skip to content

PendingBlock + Blobs module API enhancement #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigo-o opened this issue Mar 28, 2025 · 0 comments
Open

PendingBlock + Blobs module API enhancement #1406

rodrigo-o opened this issue Mar 28, 2025 · 0 comments
Labels
refactor Ideas to improve code usability or performance with little or no change to behavior

Comments

@rodrigo-o
Copy link
Collaborator

rodrigo-o commented Mar 28, 2025

There are some not-so-straightforward interactions between BlobSideCar calls PendingBlocks with added complexity due to the need of passing a callback to `

# lib/lambda_ethereum_consensus/p2p/gossip/blob_sidecar.ex
PendingBlocks.process_blobs(store, {:ok, [blob]})

# lib/lambda_ethereum_consensus/beacon/pending_blocks.ex
BlobDownloader.request_blobs_by_root(
    missing_blobs,
    &process_blobs/2,
    @download_retries
  )

...

def process_blobs(store, {:ok, blobs}) do

We need to rework the API to be more polished. We want to be able to let pending block know that a blob was downloaded without using an API that appears to point to other purpose.

@rodrigo-o rodrigo-o added the refactor Ideas to improve code usability or performance with little or no change to behavior label Mar 28, 2025
LeanSerra added a commit that referenced this issue Mar 28, 2025
Co-authored-by: Rodrigo Oliveri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Ideas to improve code usability or performance with little or no change to behavior
Projects
Status: No status
Development

No branches or pull requests

1 participant