Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEVM: EIP-7702 Debug gas_mismatch #1752

Closed
fborello-lambda opened this issue Jan 20, 2025 · 2 comments
Closed

LEVM: EIP-7702 Debug gas_mismatch #1752

fborello-lambda opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation pectra Pectra (Prague + Electra) hardfork

Comments

@fborello-lambda
Copy link
Contributor

fborello-lambda commented Jan 20, 2025

We are having some mismatches when running the ef-tests.

If we run:

make run-evm-ef-tests flags="--tests intrinsic_gas_cost.json"   

Only running the test that fails with 12500:

make run-evm-ef-tests flags="--tests intrinsic_gas_cost.json -- --specific_tests tests/prague/eip7702_set_code_tx/test_gas.py::test_intrinsic_gas_cost[fork_Prague-state_test-valid_True-multiple_valid_authorizations_single_signer]"

we get a mismatch of 12500 for the first failed test. It may be related to how we handle the refunded gas if the account is present in the trie

@fborello-lambda fborello-lambda added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation pectra Pectra (Prague + Electra) hardfork labels Jan 20, 2025
@lima-limon-inc
Copy link
Contributor

This commit appears to fix this issue.

The problem was that we were only checking the DB if the signer address existed. BUT, we only update the Cache during authority tuple processing. So, in order to check if the account existed, we need to check both the db AND the cache.

@fborello-lambda
Copy link
Contributor Author

fborello-lambda commented Jan 22, 2025

In the end, all gas issues were solved with PR #1769 and commit 5553209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation pectra Pectra (Prague + Electra) hardfork
Projects
Status: Done
Development

No branches or pull requests

2 participants