Skip to content

LEVM: Check we're using levm everywhere #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fkrause98 opened this issue Jan 17, 2025 · 0 comments · Fixed by #1755
Closed

LEVM: Check we're using levm everywhere #1746

fkrause98 opened this issue Jan 17, 2025 · 0 comments · Fixed by #1755
Assignees
@lima-limon-inc

Comments

@fkrause98
Copy link
Contributor

Changes required

Currently, we're using revm for the apply_plain_transaction, which do not depends
on a feature flag, we should use levm or add a way to use levm through a feature flag. Also, we should double check if there are any more places
where we should be using levm by default or through a feature flag.
@lima-limon-inc lima-limon-inc mentioned this issue Jan 20, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
@lima-limon-inc
fix(l1): use levm flag for apply transaction function (#1755)
6ae508e 
**Motivation**
We are using revm for the
[apply_plain_transaction](https://github.com/lambdaclass/ethrex/blob/53578fc5e3b2335d31d943f99278056c7e99566e/crates/blockchain/payload.rs#L421)
function; regardless of the EVM implementation passed as a CLI argument.

With this PR, said function will now use the EVM implementation
specified via CLI flags and will default to LEVM.

**Description**

Add both the LEVM and REVM code inside the apply_plain_transaction
function. Only the specified implementation gets compiled.

Closes #1746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lima-limon-inc lima-limon-inc

Labels
None yet
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(l1): use levm flag for apply transaction function lambdaclass/ethrex
2 participants
@fkrause98 @lima-limon-inc