-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEVM, L1: Design EVM
trait to standardize the vm
's crate interface
#1661
Comments
EVM
trait to standardize the vm
's crate interfaceEVM
trait to standardize the vm
's crate interface
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 7, 2025
Starts from scratch PR #1706 **Motivation** The feature flag is somewhat cumbersome, it's easier to build a single binary and then choose the `EVM` implementation via the CLI. **Description** - Add the CLI arg → Removes the `levm`/`revm` feature flag. - Create the `EVM` enum to handle the evms. - Create a `Blockchain` struct in order to keep track of the `EVM` selected and make use of it throughout the code. - The next step consists of abstracting the logic with a `trait` as #1661 describes --------- Co-authored-by: Tomas Fabrizio Orsi <[email protected]>
Closed
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 20, 2025
Alternative to #1897 **Motivation** When doing the `EVM` trait in #1897, i've ended up needing an enum to wrap the structs that implement such trait. This approach ended up being quite complex, and the raw use of an enum was discussed. **Description** - Implement an `enum` as unique entrypoint for the crate `ethrex-vm`. Closes #1661
JereSalo
pushed a commit
that referenced
this issue
Feb 28, 2025
Alternative to #1897 **Motivation** When doing the `EVM` trait in #1897, i've ended up needing an enum to wrap the structs that implement such trait. This approach ended up being quite complex, and the raw use of an enum was discussed. **Description** - Implement an `enum` as unique entrypoint for the crate `ethrex-vm`. Closes #1661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Abstract
Define a trait
EVM
incrates/vm/vm.rs
with methodsexecute_block
,execute_tx
,get_state_transitions
Motivation
Spec
Trait
EVM
The text was updated successfully, but these errors were encountered: