remove setting from the settings list entirely if hidden to avoid it being included in configs and commands. Will also reduce overhead from checks when drawing ui

Author: beanbag44

src/main/kotlin/com/lambda/config/AbstractSetting.kt

@@ -101,7 +101,6 @@ abstract class AbstractSetting<T : Any>(
     override var description: String,
     var visibility: () -> Boolean,
 ) : Jsonable, Nameable, Describable, Layout {
-    var hidden = false
     private val listeners = mutableListOf<ValueListener<T>>()
     var groups: MutableList<List<NamedEnum>> = mutableListOf()
 
@@ -188,7 +187,7 @@ abstract class AbstractSetting<T : Any>(
                 val previous = this@AbstractSetting.value
                 try {
                     loadFromJson(parsed)
-                } catch (e: Exception) {
+                } catch (_: Exception) {
                     return@executeWithResult failure("Failed to load $valueString as a ${type::class.simpleName} for $name in ${config.name}.")
                 }
                 ConfigCommand.info(setMessage(previous, this@AbstractSetting.value))

src/main/kotlin/com/lambda/config/groups/SettingGroup.kt

@@ -54,14 +54,14 @@ abstract class SettingGroup(val c: Configurable) {
     fun edit(
         vararg settings: KProperty0<*>,
         edits: BasicEditBuilder.() -> Unit
-    ) { BasicEditBuilder(settings.map { it.delegate } as List<AbstractSetting<*>>).apply(edits) }
+    ) { BasicEditBuilder(c, settings.map { it.delegate } as List<AbstractSetting<*>>).apply(edits) }
 
     @SettingEditorDsl
     fun editWith(
         vararg settings: KProperty0<*>,
         other: KProperty0<*>,
         edits: BasicEditBuilder.(AbstractSetting<*>) -> Unit
-    ) { BasicEditBuilder(settings.map { it.delegate } as List<AbstractSetting<*>>).edits(other.delegate as AbstractSetting<*>) }
+    ) { BasicEditBuilder(c, settings.map { it.delegate } as List<AbstractSetting<*>>).edits(other.delegate as AbstractSetting<*>) }
 
     @SettingEditorDsl
     internal inline fun <T : Any> editTyped(
@@ -78,7 +78,7 @@ abstract class SettingGroup(val c: Configurable) {
 
     @SettingEditorDsl
     fun hide(vararg settings: KProperty0<*>) =
-        (settings.map { it.delegate } as List<AbstractSetting<*>>).forEach { it.hidden = true }
+        c.settings.removeAll(settings.map { it.delegate } as List<AbstractSetting<*>>)
 
     @SettingEditorDsl
     fun KProperty0<*>.insert(insert: KProperty0<*>, insertMode: InsertMode) {
@@ -98,14 +98,15 @@ abstract class SettingGroup(val c: Configurable) {
         )
     }
 
-    open class BasicEditBuilder(open val settings: Collection<AbstractSetting<*>>) {
+    open class BasicEditBuilder(val c: Configurable, open val settings: Collection<AbstractSetting<*>>) {
         @SettingEditorDsl
         fun visibility(vis: () -> Boolean) =
             settings.forEach { it.visibility = vis }
 
         @SettingEditorDsl
-        fun hide() =
-            settings.forEach { it.hidden = true }
+        fun hide() {
+            c.settings.removeAll(settings)
+        }
 
         @SettingEditorDsl
         fun groups(vararg groups: NamedEnum) =
@@ -118,8 +119,8 @@ abstract class SettingGroup(val c: Configurable) {
 
     open class TypedEditBuilder<T : Any>(
         override val settings: Collection<AbstractSetting<T>>,
-        val c: Configurable
-    ) : BasicEditBuilder(settings) {
+        c: Configurable
+    ) : BasicEditBuilder(c, settings) {
         @SettingEditorDsl
         fun defaultValue(value: T) =
             settings.forEach {

src/main/kotlin/com/lambda/gui/components/SettingsWidget.kt

@@ -41,7 +41,7 @@ object SettingsWidget {
         }
         separator()
         val toIgnoreSettings = if (config is Module) setOf(config.keybindSetting, config.disableOnReleaseSetting) else emptySet()
-        val visibleSettings = config.settings.filter { it.visibility() && !it.hidden } - toIgnoreSettings
+        val visibleSettings = config.settings.filter { it.visibility() } - toIgnoreSettings
         val (grouped, ungrouped) = visibleSettings.partition { it.groups.isNotEmpty() }
         ungrouped.forEach { with(it) { buildLayout() } }
         renderGroup(grouped, emptyList(), config)