Fixed plotting and added snapping guides

Author: Avanatiker

src/main/kotlin/com/lambda/gui/components/HudGuiLayout.kt

@@ -20,30 +20,195 @@ package com.lambda.gui.components
 import com.lambda.core.Loadable
 import com.lambda.event.events.GuiEvent
 import com.lambda.event.listener.SafeListener.Companion.listen
+import com.lambda.gui.dsl.ImGuiBuilder
 import com.lambda.gui.dsl.ImGuiBuilder.buildLayout
+import com.lambda.gui.snap.Guide
+import com.lambda.gui.snap.RectF
+import com.lambda.gui.snap.SnapManager
 import com.lambda.module.HudModule
 import com.lambda.module.ModuleRegistry
+import com.lambda.module.modules.client.GuiSettings
+import com.lambda.module.modules.client.ClickGui
+import imgui.ImGui
+import imgui.ImDrawList
+import imgui.flag.ImDrawListFlags
 import imgui.flag.ImGuiWindowFlags
+import kotlin.math.PI
 
 object HudGuiLayout : Loadable {
     const val DEFAULT_HUD_FLAGS =
         ImGuiWindowFlags.NoDecoration or
                 ImGuiWindowFlags.NoBackground or
                 ImGuiWindowFlags.AlwaysAutoResize or
                 ImGuiWindowFlags.NoDocking
+    private var activeDragHudName: String? = null
+    private var mouseWasDown = false
+    private var dragOffsetX = 0f
+    private var dragOffsetY = 0f
+    private val lastBounds = mutableMapOf<String, RectF>()
+    private val pendingPositions = mutableMapOf<String, Pair<Float, Float>>()
+    private val snapOverlays = mutableMapOf<String, SnapVisual>()
+
+    private data class SnapVisual(
+        val snapX: Float?,
+        val snapY: Float?,
+        val kindX: Guide.Kind?,
+        val kindY: Guide.Kind?
+    )
+
+    // Precomputed Float PI values to avoid repeated conversions
+    private const val PI_F = PI.toFloat()
+    private const val HALF_PI_F = (0.5f * PI).toFloat()
+    private const val THREE_HALVES_PI_F = (1.5f * PI).toFloat()
+    private const val TWO_PI_F = (2f * PI).toFloat()
 
     init {
         listen<GuiEvent.NewFrame> {
             buildLayout {
-                ModuleRegistry.modules
+                val vp = ImGui.getMainViewport()
+                SnapManager.beginFrame(vp.sizeX, vp.sizeY, io.fontGlobalScale)
+
+                val mouseDown = io.mouseDown[0]
+                val mousePressedThisFrame = mouseDown && !mouseWasDown
+                val mouseReleasedThisFrame = !mouseDown && mouseWasDown
+                mouseWasDown = mouseDown
+                if (mouseReleasedThisFrame) {
+                    activeDragHudName = null
+                }
+
+                pendingPositions.clear()
+                snapOverlays.clear()
+
+                val huds = ModuleRegistry.modules
                     .filterIsInstance<HudModule>()
                     .filter { it.isEnabled }
-                    .forEach { hud ->
-                        window("##${hud.name}", flags = DEFAULT_HUD_FLAGS) {
-                            with(hud) { buildLayout() }
+
+                if (ClickGui.isEnabled && activeDragHudName == null && mousePressedThisFrame) {
+                    tryBeginDrag(huds)
+                }
+
+                if (ClickGui.isEnabled && activeDragHudName != null && mouseDown) {
+                    updateDragAndSnapping()
+                }
+
+                huds.forEach { hud ->
+                    val override = pendingPositions[hud.name]
+                    if (override != null) {
+                        ImGui.setNextWindowPos(override.first, override.second)
+                    }
+                    window("##${hud.name}", flags = DEFAULT_HUD_FLAGS) {
+                        val vis = snapOverlays[hud.name]
+                        if (vis != null) {
+                            SnapManager.drawSnapLines(
+                                foregroundDrawList,
+                                vis.snapX, vis.kindX,
+                                vis.snapY, vis.kindY
+                            )
                         }
+                        with(hud) { buildLayout() }
+                        // Rounded-corner only outline; pull parameters from settings
+                        if (ClickGui.isEnabled) {
+                            drawHudOutline(
+                                draw = foregroundDrawList,
+                                x = windowPos.x,
+                                y = windowPos.y,
+                                w = windowSize.x,
+                                h = windowSize.y
+                            )
+                        }
+                        val p = windowPos
+                        val s = windowSize
+                        val rect = RectF(p.x, p.y, s.x, s.y)
+                        SnapManager.registerElement(hud.name, rect)
+                        lastBounds[hud.name] = rect
                     }
+                }
             }
         }
     }
+
+    private fun ImGuiBuilder.tryBeginDrag(huds: List<HudModule>) {
+        val mx = io.mousePos.x
+        val my = io.mousePos.y
+        huds.forEach { hud ->
+            val r = lastBounds[hud.name] ?: return@forEach
+            val inside = mx >= r.x && mx <= r.x + r.w && my >= r.y && my <= r.y + r.h
+            if (inside) {
+                activeDragHudName = hud.name
+                dragOffsetX = mx - r.x
+                dragOffsetY = my - r.y
+                return
+            }
+        }
+    }
+
+    private fun ImGuiBuilder.updateDragAndSnapping() {
+        val id = activeDragHudName ?: return
+        val last = lastBounds[id] ?: return
+        val mx = io.mousePos.x
+        val my = io.mousePos.y
+        val targetX = mx - dragOffsetX
+        val targetY = my - dragOffsetY
+        val proposed = RectF(targetX, targetY, last.w, last.h)
+        val snap = SnapManager.computeSnap(proposed, id)
+        val finalX = targetX + snap.dx
+        val finalY = targetY + snap.dy
+        pendingPositions[id] = finalX to finalY
+        snapOverlays[id] = SnapVisual(snap.snapX, snap.snapY, snap.kindX, snap.kindY)
+    }
+
+    private fun ImGuiBuilder.drawHudOutline(draw: ImDrawList, x: Float, y: Float, w: Float, h: Float) {
+        val baseRadius = GuiSettings.hudOutlineCornerRadius
+        val rounding = if (baseRadius > 0f) baseRadius else style.windowRounding
+        val inflate = GuiSettings.hudOutlineCornerInflate
+        // Soft halo corners (gray, slightly smaller)
+        drawCornerArcs(
+            draw,
+            x, y, w, h,
+            (rounding + inflate).coerceAtLeast(0f),
+            GuiSettings.hudOutlineHaloColor.rgb,
+            GuiSettings.hudOutlineHaloThickness
+        )
+        // Crisp inner corner arcs
+        drawCornerArcs(
+            draw,
+            x, y, w, h,
+            rounding.coerceAtLeast(0f),
+            GuiSettings.hudOutlineBorderColor.rgb,
+            GuiSettings.hudOutlineBorderThickness
+        )
+    }
+
+    private fun drawCornerArcs(
+        draw: ImDrawList,
+        x: Float, y: Float, w: Float, h: Float,
+        radius: Float,
+        color: Int,
+        thickness: Float
+    ) {
+        if (radius <= 0f || thickness <= 0f) return
+        val tlCx = x + radius
+        val tlCy = y + radius
+        val trCx = x + w - radius
+        val trCy = y + radius
+        val brCx = x + w - radius
+        val brCy = y + h - radius
+        val blCx = x + radius
+        val blCy = y + h - radius
+
+        fun strokeArc(cx: Float, cy: Float, start: Float, end: Float) {
+            draw.pathClear()
+            draw.pathArcTo(cx, cy, radius, start, end, 0)
+            draw.pathStroke(color, ImDrawListFlags.None, thickness)
+        }
+
+        // TL: pi -> 1.5pi
+        strokeArc(tlCx, tlCy, PI_F, THREE_HALVES_PI_F)
+        // TR: 1.5pi -> 2pi
+        strokeArc(trCx, trCy, THREE_HALVES_PI_F, TWO_PI_F)
+        // BR: 0 -> 0.5pi
+        strokeArc(brCx, brCy, 0f, HALF_PI_F)
+        // BL: 0.5pi -> pi
+        strokeArc(blCx, blCy, HALF_PI_F, PI_F)
+    }
 }

src/main/kotlin/com/lambda/gui/dsl/ImGuiBuilder.kt

@@ -1272,7 +1272,7 @@ object ImGuiBuilder {
      * @param scaleMin Minimum scale value
      * @param scaleMax Maximum scale value
      * @param graphSize Size of the graph
-     * @param stride Stride between values
+     * @param stride Sample decimation step (>= 1). Use 0/1 for contiguous data.
      */
     @ImGuiDsl
     fun plotLines(
@@ -1283,8 +1283,17 @@ object ImGuiBuilder {
         scaleMin: Float = Float.MAX_VALUE,
         scaleMax: Float = Float.MAX_VALUE,
         graphSize: ImVec2 = ImVec2(),
-        stride: Int = 1,
-    ) = ImGui.plotLines(label, values, valuesOffset, overlayText, scaleMin, scaleMax, graphSize, stride)
+        stride: Int = 0,
+    ) {
+        val (src, sMin, sMax) = preparePlotSeries(values, stride, scaleMin, scaleMax)
+        val count = src.size
+        val offset = if (count == 0) 0 else valuesOffset.coerceIn(0, count - 1)
+        if (count < 2) {
+            plotLines(label, floatArrayOf(), 0, 0, overlayText, sMin, sMax, graphSize.x, graphSize.y)
+            return
+        }
+        plotLines(label, src, count, offset, overlayText, sMin, sMax, graphSize.x, graphSize.y)
+    }
 
     /**
      * Creates a plot of histogram values.
@@ -1296,7 +1305,7 @@ object ImGuiBuilder {
      * @param scaleMin Minimum scale value
      * @param scaleMax Maximum scale value
      * @param graphSize Size of the graph
-     * @param stride Stride between values
+     * @param stride Sample decimation step (>= 1). Use 0/1 for contiguous data.
      */
     @ImGuiDsl
     fun plotHistogram(
@@ -1307,8 +1316,61 @@ object ImGuiBuilder {
         scaleMin: Float = Float.MAX_VALUE,
         scaleMax: Float = Float.MAX_VALUE,
         graphSize: ImVec2 = ImVec2(),
-        stride: Int = 1,
-    ) = ImGui.plotHistogram(label, values, valuesOffset, overlayText, scaleMin, scaleMax, graphSize, stride)
+        stride: Int = 0,
+    ) {
+        val (src, sMin, sMax) = preparePlotSeries(values, stride, scaleMin, scaleMax)
+        val count = src.size
+        val offset = if (count == 0) 0 else valuesOffset.coerceIn(0, count - 1)
+        if (count < 1) {
+            plotHistogram(label, floatArrayOf(), 0, 0, overlayText, sMin, sMax, graphSize.x, graphSize.y)
+            return
+        }
+        plotHistogram(label, src, count, offset, overlayText, sMin, sMax, graphSize.x, graphSize.y)
+    }
+
+    private fun preparePlotSeries(
+        values: FloatArray,
+        stride: Int,
+        scaleMin: Float,
+        scaleMax: Float
+    ): Triple<FloatArray, Float, Float> {
+        val contiguous = (stride <= 1)
+        val src = if (contiguous) {
+            values
+        } else {
+            val outSize = (values.size + stride - 1) / stride
+            val out = FloatArray(outSize)
+            var i = 0
+            var j = 0
+            while (i < values.size) {
+                out[j++] = values[i]
+                i += stride
+            }
+            out
+        }
+        var sMin = scaleMin
+        var sMax = scaleMax
+        if (sMin == Float.MAX_VALUE && sMax == Float.MAX_VALUE) {
+            var minV = Float.POSITIVE_INFINITY
+            var maxV = Float.NEGATIVE_INFINITY
+            for (v in src) if (v.isFinite()) {
+                if (v < minV) minV = v
+                if (v > maxV) maxV = v
+            }
+            if (!minV.isFinite() || !maxV.isFinite()) {
+                minV = 0f; maxV = 1f
+            }
+            if (minV == maxV) {
+                val base = if (minV == 0f) 1f else kotlin.math.abs(minV)
+                val pad = base * 0.01f
+                minV -= pad
+                maxV += pad
+            }
+            sMin = minV
+            sMax = maxV
+        }
+        return Triple(src, sMin, sMax)
+    }
 
     /**
      * Creates a main menu bar.
@@ -1485,7 +1547,7 @@ object ImGuiBuilder {
      *
      * @param title Title of the modal
      * @param value Boolean reference to control visibility
-     * @param flags Additional window flags
+     * @param windowFlags Additional window flags
      * @param block Content of the modal
      *
      * @see ImGuiPopupFlags

src/main/kotlin/com/lambda/gui/snap/Guide.kt

@@ -0,0 +1,28 @@
+/*
+ * Copyright 2025 Lambda
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.lambda.gui.snap
+
+data class Guide(
+    val orientation: Orientation,
+    val pos: Float,
+    val strength: Int,
+    val kind: Kind
+) {
+    enum class Orientation { Vertical, Horizontal }
+    enum class Kind { ElementEdge, ElementCenter, ScreenCenter, Grid }
+}

src/main/kotlin/com/lambda/gui/snap/RectF.kt

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2025 Lambda
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.lambda.gui.snap
+
+data class RectF(val x: Float, val y: Float, val w: Float, val h: Float) {
+    val left get() = x
+    val right get() = x + w
+    val top get() = y
+    val bottom get() = y + h
+    val cx get() = x + w * 0.5f
+    val cy get() = y + h * 0.5f
+}