Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the way we do snapshots #716

Open
gbenhaim opened this issue May 6, 2018 · 0 comments
Open

Refactor the way we do snapshots #716

gbenhaim opened this issue May 6, 2018 · 0 comments
Labels
enhancement

Comments

@gbenhaim
Copy link
Member

gbenhaim commented May 6, 2018

  • Currently, only live snapshot is supported.
  • The snapshot is created using libvirt, but the revert process uses qemu-img commands directly.

I think that we should use only libvirt's api for managing snapshot, and both live/dead snapshots should be supported.

For implementing dead snapshots, we will have to change the domain type from transient to persistent, since transient domains get undefined when shutting them down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbenhaim