-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change --text from argument to option #28
Draft
maresb
wants to merge
10
commits into
labelle-org:main
Choose a base branch
from
maresb:change-text-to-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
991be35
Revert "Make text option an argument instead of an option"
maresb 3723595
Hint on missing --text flag
maresb 02c4dbf
Add a test for the --text hint
maresb 4d72722
Use shlex to ensure correct shell escaping
maresb e8d8147
Update README with --text
maresb 862fe9a
Use proper fenced code blocks in README
maresb a7701ff
Improve README modes section
maresb ce4f97f
Fix --qr
maresb 7edc262
Fix multiline
maresb 26adfac
Add preview images to README
maresb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't test it, so I might be wrong here, but I think this function should return
True
in case it found "No such command" and updated the message.In case of
True
, it should do the following two lines:Otherwise, it should
raise
.This way we'll get proper error/exception handling by
typer
, except for this specific case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function only runs if there is an exception. In that case, it doesn't handle the exception, it simply mutates the message when necessary. Those two lines run in any case in order to handle the exception, so I don't see how returning a boolean would help. Does that make sense?
The goal is basically to handle the
standalone_mode=False
branches from the code linked in the comment. Based on my own tests I think it's working well, but it'd be great if you could try if you can break something.