From 786f34db27e402c907b16355d7d7cc7404167510 Mon Sep 17 00:00:00 2001 From: "Suraj N. Kurapati" Date: Fri, 12 Apr 2013 20:25:14 -0700 Subject: [PATCH 1/4] item close button did not appear under Ext 4.2.0 --- src/BoxSelect.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BoxSelect.js b/src/BoxSelect.js index 7060292..6ae1138 100644 --- a/src/BoxSelect.js +++ b/src/BoxSelect.js @@ -1067,7 +1067,7 @@ Ext.define('Ext.ux.form.field.BoxSelect', { me.multiSelectItemTpl = [ '', - '
  • ', ' selected', '', From 64efe48f08d15ba15cd957e680ecb4e08be2e2af Mon Sep 17 00:00:00 2001 From: "Suraj N. Kurapati" Date: Wed, 17 Apr 2013 18:58:35 -0700 Subject: [PATCH 2/4] previous selection lost upon making new selection The set of filtered records (valueStore) were REPLACED by selected records in the page currently loaded in the combo box store (store). Consequently, the user's previous selection was lost when the user made a new selection from a disjoint page loaded into the combo box store. --- src/BoxSelect.js | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/BoxSelect.js b/src/BoxSelect.js index 6ae1138..0c244b6 100644 --- a/src/BoxSelect.js +++ b/src/BoxSelect.js @@ -554,30 +554,21 @@ Ext.define('Ext.ux.form.field.BoxSelect', { * Used to determine if a record is filtered out of the current store's data set, * for determining if a currently selected value should be retained. * - * Slightly complicated logic. A record is considered filtered and should be retained if: + * A record is considered filtered and should be retained if: * - * - It is not in the combo store and the store has no filter or it is in the filtered data set + * - It is not in the combo store and it is in the value store * (Happens when our selected value is just part of a different load, page or query) - * - It is not in the combo store and forceSelection is false and it is in the value store * (Happens when our selected value was created manually) * * @private */ isFilteredRecord: function(record) { var me = this, - store = me.store, valueField = me.valueField, - storeRecord, - filtered = false; + value = record.get(valueField); - storeRecord = store.findExact(valueField, record.get(valueField)); - - filtered = ((storeRecord === -1) && (!store.snapshot || (me.findRecord(valueField, record.get(valueField)) !== false))); - - filtered = filtered || (!filtered && (storeRecord === -1) && (me.forceSelection !== true) && - (me.valueStore.findExact(valueField, record.get(valueField)) >= 0)); - - return filtered; + return (me.store.findExact(valueField, value) === -1) && + (me.valueStore.findExact(valueField, value) !== -1); }, /** From 2cbda243b4c13a53a825061534fcaf23925e85cd Mon Sep 17 00:00:00 2001 From: "Suraj N. Kurapati" Date: Thu, 18 Apr 2013 10:28:05 -0700 Subject: [PATCH 3/4] fix oversized styling of combo box under Ext 4.2.0 This solution was contributed by user "WebProgrammer" on Sencha Forums: http://www.sencha.com/forum/showthread.php?134751&p=952915 --- src/BoxSelect.css | 1 + 1 file changed, 1 insertion(+) diff --git a/src/BoxSelect.css b/src/BoxSelect.css index 4920654..e37b1b1 100644 --- a/src/BoxSelect.css +++ b/src/BoxSelect.css @@ -6,6 +6,7 @@ } .x-boxselect ul.x-boxselect-list { padding: 1px 3px; + margin: 0px; } ul.x-boxselect-list.x-boxselect-singleselect { white-space: nowrap; From 8fbdbc8f7195b62d428fee8af74ab9541dd522d6 Mon Sep 17 00:00:00 2001 From: "Suraj N. Kurapati" Date: Thu, 18 Apr 2013 15:11:32 -0700 Subject: [PATCH 4/4] error underlining did not appear under Ext 4.2.0 --- src/BoxSelect.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BoxSelect.css b/src/BoxSelect.css index e37b1b1..38be90f 100644 --- a/src/BoxSelect.css +++ b/src/BoxSelect.css @@ -20,7 +20,7 @@ ul.x-boxselect-list.x-boxselect-singleselect { } .x-boxselect-input input, .x-boxselect-input div { border: none; - background: none; + background-color: inherit; line-height: 18px !important; height: 20px; width: 100%;