Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port RhythmBox plugin #33

Closed
khurshid-alam opened this issue Feb 10, 2017 · 7 comments
Closed

Port RhythmBox plugin #33

khurshid-alam opened this issue Feb 10, 2017 · 7 comments

Comments

@khurshid-alam
Copy link

Nice to see some activity after after long. Please port Rhythmbox plugin.

Thanks.

@bluss
Copy link
Member

bluss commented Feb 10, 2017

Related to mpris support. I would prefer to see a more general way here. Although mpris may not cover library support for Rhythmbox.

@khurshid-alam
Copy link
Author

@bluss

Python2 implementation of the mpris plugin can be found here: https://github.com/hugosenari/Kupfer-Plugins/tree/master/mpris_2 by @hugosenari.

I also commented on the issue asking the author if he wants to port his mpris plugin (hugosenari/Kupfer-Plugins#2)

@bluss
Copy link
Member

bluss commented Feb 11, 2017

Ah it looks close to what I'd envision too (and have actually prototyped something simple like that)

Source: Players: Lists each active mpris player, with Play, Pause next, prev etc

hugosenari's idea of setting the last used one is valuable. I had an idea of an explicit action to lift any active one to be the primary one.

Rhythmbox doesn't support sending the library over mpris' dbus api, and neither does audacious, so it looks like it needs custom code for each player to get the library

@bluss
Copy link
Member

bluss commented Feb 11, 2017

See #34

@hugosenari
Copy link

Thank @khurshid-alam.
No change was required to run mpris_2.py.
Only mpris_2_plus.py don't work anymore. I will take a look some day.
And is good to see that now we also have an option with less external dependency, good work @bluss.

@bluss
Copy link
Member

bluss commented Feb 12, 2017

Hi @hugosenari you've created a very interesting project with the kupfer plugin marketplace. It's a great idea, it really needs something like that.

@bluss
Copy link
Member

bluss commented Feb 20, 2017

Library and play/queue support is back in the plugin, but I'm not 100% happy with the interaction with the queue. the details are up for discussion. (Like: When playing a single song, should it clear the queue or not?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants