Fixes nil map bug on creation (#1743) (#1746)

Co-authored-by: Alena Varkockova <[email protected]> Signed-off-by: Ken Sipe <[email protected]>
kudobuilder · Nov 16, 2020 · d902714 · d902714
1 parent f7fa143
commit d902714
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/webhook/instance_admission.go b/pkg/webhook/instance_admission.go
@@ -464,6 +464,9 @@ func validateParameters(ov *kudoapi.OperatorVersion, instance *kudoapi.Instance)
 func setImmutableParameterDefaults(ov *kudoapi.OperatorVersion, instance *kudoapi.Instance) {
 	for _, p := range ov.Spec.Parameters {
 		if p.IsImmutable() && p.HasDefault() {
+			if instance.Spec.Parameters == nil {
+				instance.Spec.Parameters = map[string]string{}
+			}
 			if _, ok := instance.Spec.Parameters[p.Name]; !ok {
 				instance.Spec.Parameters[p.Name] = *p.Default
 			}

diff --git a/test/upgrade/cert-manager-detection/06-install-kudo.yaml b/test/upgrade/cert-manager-detection/06-install-kudo.yaml
@@ -1,5 +1,5 @@
 apiVersion: kudo.dev/v1beta1
 kind: TestStep
 commands:
-  - command: sleep 10
+  - command: sleep 20
   - command: kubectl kudo init -v 4 --kudo-image kudobuilder/controller:test --kudo-image-pull-policy IfNotPresent --wait