-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): howto use policy groups. #454
Conversation
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for your consideration.
I thought they were quite similar, other than being in explanations and howtos. Maybe that's the distinction. Maybe another iteration of both, focusing on a better separation of the content into howto and explanation might be worth doing. |
I think the whole first part could be replaced with: Prior to working with Policy Groups, consult the explanation for them. Then another look at what remains. The example is very similar to that in explanations. Say, something, like: Using the example from [the explanation of Policy Groups](link to the example) use these commands to implement (or define) it. Commands Output. That should do. The Context aware rules section is already covered in Context-Aware policies in the explanation (I think) so could be dispensed with. What do you think? |
3207357
to
3749fe5
Compare
@jhkrug I've made the changes you described |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two little suggestions to consider, but otherwise lgtm.
Adds a new Howto page showing how to use the policy groups. Signed-off-by: José Guilherme Vanz <[email protected]> Co-authored-by: John Krug <[email protected]> Co-authored-by: Flavio Castelli <[email protected]>
669622b
to
664ec40
Compare
@jhkrug thanks for the last review |
Description
Adds a new Howto page showing how to use the policy groups.
Fix #449