[scanner] fix: add loading states to async button handlers by clubanderson · Pull Request #21295 · kubestellar/console

clubanderson · 2026-07-19T20:05:10Z

Changes

Add missing isLoading/disabled states to three async button handlers that lacked visual feedback during in-flight operations:

`NamespaceAccessPanel` — revoke access button

Add revokingBindingName state (per-entry) to handleRevokeAccess
Disable the revoke button and show a Loader2 spinner while the DELETE rolebinding call is in flight
Prevents double-submission on the RBAC revoke action

`UserManagementModal` — delete user confirmation

Change onConfirm type to (userId: string) => Promise<void>
Add isDeleting state; pass isLoading={isDeleting} to ConfirmDialog
Confirm button is now disabled while the async delete resolves

`UserManagementList` + `UserManagement.types`

Update onDeleteUser type to Promise<void> to match the async handleDeleteUser implementation
Remove premature setDeleteConfirmUserId(null) so the modal stays open until the operation completes

- NamespaceAccessPanel: add per-entry revokingBindingName state to handleRevokeAccess; disable and show spinner on revoke button during the DELETE rolebinding call to prevent double-submission - UserManagementModal: change DeleteUserConfirmModal.onConfirm type to Promise<void>, add isDeleting state, pass isLoading to ConfirmDialog so the confirm button is disabled while the delete is in flight - UserManagementList: remove premature setDeleteConfirmUserId(null) so the modal stays open until the async delete resolves/rejects - UserManagement.types: update onDeleteUser signature to Promise<void> Fixes #21293 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Scanner <scanner@kubestellar.io>

kubestellar-prow · 2026-07-19T20:05:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-07-19T20:05:14Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`8aaa518`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a5d39dacf9d34000822436d
😎 Deploy Preview	https://deploy-preview-21295.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-07-19T20:05:17Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-07-19T20:05:19Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-07-19T20:05:38Z

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

github-actions · 2026-07-19T20:05:40Z

Auto Test Generator

The following new files have no corresponding test file:

web/src/components/cards/UserManagement.types.ts
web/src/components/cards/UserManagementList.tsx
web/src/components/cards/UserManagementModal.tsx

Please add tests or apply the needs-tests label to track this PR.

github-actions · 2026-07-19T20:06:30Z

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.

Powered by axe-core. Target: WCAG 2.1 AA compliance.

Copilot

Pull request overview

Adds in-flight UX feedback (loading + disabled states) for destructive async actions so users get clear progress indication and double-submissions are avoided across namespace access revocation and console user deletion flows.

Changes:

NamespaceAccessPanel: disables the revoke button and shows a spinner while the DELETE rolebinding request is in flight.
UserManagementModal/UserManagementList: makes delete confirmation async-aware and wires isLoading through ConfirmDialog to disable buttons during deletion.
Updates onDeleteUser typing to return Promise<void> to match the async delete implementation.

Note: build/lint are validated by CI on the PR (per AGENTS.md).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
web/src/components/namespaces/NamespaceAccessPanel.tsx	Adds revoke-button loading/disabled state while RBAC revocation runs.
web/src/components/cards/UserManagementModal.tsx	Adds `isDeleting` state and passes `isLoading` to `ConfirmDialog` while awaiting async confirm.
web/src/components/cards/UserManagementList.tsx	Keeps delete confirm modal open until the async delete finishes by awaiting `onConfirm`.
web/src/components/cards/UserManagement.types.ts	Updates `onDeleteUser` to return `Promise<void>` to reflect async behavior.

+    setRevokingBindingName(binding.bindingName)
    try {
      const params = new URLSearchParams({


    if (!window.confirm(`Revoke access for ${binding.subjectName}?`)) {
      return


      console.error('Failed to revoke access:', err)
      showToast('Failed to revoke access', 'error')


github-actions · 2026-07-19T20:56:22Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-07-19T21:05:04Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 0bc9e56a0aea513065512b8b64b5997ae7277701.

github-actions · 2026-07-19T21:06:15Z

✅ Post-Merge Verification: passed

Commit: 0bc9e56a0aea513065512b8b64b5997ae7277701
Specs run: Dashboard.spec.ts NamespaceOverview.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/29703441527

Copilot AI review requested due to automatic review settings July 19, 2026 20:05

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 19, 2026

github-actions Bot added the tier/2-standard label Jul 19, 2026

kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2026

github-actions Bot added the ai-generated Pull request generated by AI label Jul 19, 2026

Copilot started reviewing on behalf of clubanderson July 19, 2026 20:05 View session

Copilot AI reviewed Jul 19, 2026

View reviewed changes

Merge branch 'main' into scanner/fix-21293

8aaa518

clubanderson merged commit 0bc9e56 into main Jul 19, 2026
30 of 33 checks passed

kubestellar-prow Bot deleted the scanner/fix-21293 branch July 19, 2026 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[scanner] fix: add loading states to async button handlers - #21295

[scanner] fix: add loading states to async button handlers#21295
clubanderson merged 2 commits into
mainfrom
scanner/fix-21293

clubanderson commented Jul 19, 2026

Uh oh!

kubestellar-prow Bot commented Jul 19, 2026

Uh oh!

netlify Bot commented Jul 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if (!window.confirm(`Revoke access for ${binding.subjectName}?`)) {
		return

		console.error('Failed to revoke access:', err)
		showToast('Failed to revoke access', 'error')

Uh oh!

Conversation

clubanderson commented Jul 19, 2026

Changes

NamespaceAccessPanel — revoke access button

UserManagementModal — delete user confirmation

UserManagementList + UserManagement.types

Uh oh!

kubestellar-prow Bot commented Jul 19, 2026

Uh oh!

netlify Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

✅ Test Coverage Check

Uh oh!

github-actions Bot commented Jul 19, 2026

Auto Test Generator

Uh oh!

github-actions Bot commented Jul 19, 2026

♿ Accessibility Audit (WCAG 2.1 AA)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026

✅ Post-Merge Verification: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`NamespaceAccessPanel` — revoke access button

`UserManagementModal` — delete user confirmation

`UserManagementList` + `UserManagement.types`

netlify Bot commented Jul 19, 2026 •

edited

Loading