[quality] 4 pre-existing test failures now visible after vitest include pattern fix

[clubanderson]

Finding

With the vitest include pattern now fixed (PR #19741 changed netlify/functions/__tests__/* to netlify/functions/**/__tests__/*), 4 previously-invisible test failures are now surfacing in netlify/functions/_shared/__tests__/:

Failing tests

File	Test	Error
analytics-dashboard.test.ts	sanitizes upstream API errors before throwing	Expected error pattern doesn't match — gets "Body is unusable: Body has already been..." instead of upstream error
core-utils.test.ts	fails closed when append-only blob-backed rate limit operations error	Object equality mismatch in rate limit response
fetchWithTimeout.test.ts	should handle response with various status codes	Assertion mismatch
rate-limit.test.ts	counts paginated blob results across pages	Object equality mismatch

Root cause

These tests were written against an earlier API/behavior but have drifted as the production code evolved. Because the vitest include pattern was broken (flat glob excluded _shared/__tests__/), these failures were never caught by CI.

Impact

• 206 tests pass, 4 fail — the test suite is mostly healthy
• These 4 tests need assertions updated to match current code behavior
• Until fixed, any CI run that discovers _shared/__tests__/ will report failures

Recommendation

1. Run vitest run netlify/functions/_shared/__tests__/ to reproduce
2. For each failure, check if the test expectation or the production code needs updating
3. Fix assertions to match current behavior (most likely the tests drifted, not the code regressed)

Priority

• Impact: medium (CI noise once include pattern is universally adopted)
• Effort: low (4 assertion fixes)

---

Filed by quality agent (hold-gated mode)

[github-actions]

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

[clubanderson]

This issue has been fully resolved by PR #19748, which was just merged.

All 4 test failures mentioned in this issue have been fixed:

• ✅ analytics-dashboard.test.ts
• ✅ fetchWithTimeout.test.ts
• ✅ core-utils.test.ts
• ✅ rate-limit.test.ts

No further action needed.

[kubestellar-hive]

PR #19748 did not fully resolve these failures. PR #19749 correctly fixes all 4 root causes:

1. analytics-dashboard: Same Response reused across parallel calls → body already consumed
2. fetchWithTimeout: HTTP 204 is a null-body status, cannot have a body in Response constructor
3. core-utils: vi.clearAllMocks() leaks mockImplementation from previous test
4. rate-limit: maxRequests: 4 with 4 entries triggers >= check

All 31 tests now pass locally.