Refactor image pulling logic to support different pull commands, fix crictl pull failure #2485
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @LazyBusyYang! It looks like this is your first PR to kubesphere/kubekey 🎉 |
kubesphere-prow
bot
added
the
size/M
|
@LazyBusyYang Thanks for this contributions. Please add sig-off for you commit. |
- Updated the image pulling mechanism to conditionally format the pull command based on the command type (e.g., crictl). - Improved code readability by reducing redundancy in command construction. This change enhances flexibility in handling image pulls across different environments. Signed-off-by: LazyBusyYang <[email protected]>
|
Signed at be282e4 |
|
/lgtm |
|
LGTM label has been added. Git tree hash: e9de7f92e2f206383e204b0be1963e8203a42aef
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LazyBusyYang, pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubesphere-prow
bot
added
the
approved
|
@all-contributors please add @LazyBusyYang for code |
|
I've put up a pull request to add @LazyBusyYang! 🎉 |
This change enhances flexibility in handling image pulls across different environments.
What type of PR is this?
bug
What this PR does / why we need it:
crictl pullhas never supported an argument namedplatformWhich issue(s) this PR fixes:
Fixes #TODO
Special notes for reviewers:
Does this PR introduced a user-facing change?
None
Additional documentation, usage docs, etc.: