Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct Kong service port for ingress based on TLS settings #9863

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: use correct Kong service port for ingress based on TLS settings #9863

merged 1 commit into from
Jan 30, 2025

Conversation

hamadodene
Copy link
Contributor

fix #9861

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 16, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @hamadodene!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2025
@hamadodene hamadodene changed the title Use correct Kong service port for ingress based on TLS settings Fix: Use correct Kong service port for ingress based on TLS settings Jan 16, 2025
@hamadodene
Copy link
Contributor Author

@desaintmartin @shu-mutou Could you please take a look?

floreks
floreks approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2025
@floreks floreks added kind/bug Categorizes issue or PR as related to a bug. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2025
@floreks floreks changed the title Fix: Use correct Kong service port for ingress based on TLS settings fix: use correct Kong service port for ingress based on TLS settings Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.87%. Comparing base (31f5d62) to head (715bed8).
Report is 36 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9863      +/-   ##
==========================================
- Coverage   35.88%   35.87%   -0.01%     
==========================================
  Files         301      301              
  Lines       14503    14503              
  Branches      202      202              
==========================================
- Hits         5204     5203       -1     
+ Misses       9075     9023      -52     
- Partials      224      277      +53

@maciaszczykm
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, hamadodene, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 126d382 into kubernetes:master Jan 30, 2025
24 of 31 checks passed
@hamadodene hamadodene mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

@desaintmartin desaintmartin Awaiting requested review from desaintmartin

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart Uses Kong TLS Port Despite TLS Disabled in Kubernetes Dashboard Ingress
4 participants
@hamadodene @k8s-ci-robot @maciaszczykm @floreks