Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] Support kubernetes 1.31.1 #11533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[kubernetes] Support kubernetes 1.31.1 #11533

wants to merge 1 commit into from
+57 −4

Conversation

philipsabri
Copy link

@philipsabri philipsabri commented Sep 13, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support Kubernetes 1.31

Which issue(s) this PR fixes:

Fixes #11523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Make kubernetes v1.31.1 default
Add hashes for Kubernetes 1.31.0 and 1.31.1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @philipsabri!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @philipsabri. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
@philipsabri
Copy link
Author

I followed #11343 as an example, but do I need to create a PR for the hashes prior to this similar to #11261, or is this good enough?

@tico88612
Copy link
Member

You should add hashes before.

@mzaian
Copy link
Contributor

mzaian commented Sep 13, 2024

I followed #11343 as an example, but do I need to create a PR for the hashes prior to this similar to #11261, or is this good enough?

Just add the hashes into this PR.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
@yankay
Copy link
Member

yankay commented Sep 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2024
@philipsabri
Copy link
Author

Hmm I assume this is why the tests are failing

fatal: [instance-2]: FAILED! => {"attempts": 4, "changed": true, "checksum_dest": null, "checksum_src": "47f2ade14d96ffe23c50c43f618dec0ff761d401", "dest": "/builds/kargo-ci/kubernetes-sigs-kubespray/downloads/crictl-v1.31.0-linux-amd64.tar.gz", "elapsed": 0, "msg": "The checksum for /builds/kargo-ci/kubernetes-sigs-kubespray/downloads/crictl-v1.31.0-linux-amd64.tar.gz did not match d465edf8268299098013c9f484aeef7179fe992a03567fc8c430fb1079aaf979; it was 9daa32308090aedee5a7f2ab1f1428fef6f669a64e993f0b5b98db8ef6edd71b.", "src": "/home/kubespray/.ansible/tmp/ansible-tmp-1726281259.3226793-2329-251837863028722/tmpgpd6lvju", "url": "https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.31.0/crictl-v1.31.0-linux-amd64.tar.gz"}

I am using the python script to get the hashes though. Do you manually add them in these cases?

@tico88612 tico88612 mentioned this pull request Sep 14, 2024
Merged
@tico88612
Copy link
Member

I am using the python script to get the hashes though. Do you manually add them in these cases?

I've pushed a fix to download_hash.py so you can manually fix the hash of crictl.

#11534

@philipsabri philipsabri force-pushed the feature/k8s-1.31 branch 2 times, most recently from f1df38c to 8bcf4cd Compare September 14, 2024 17:38
@philipsabri
Copy link
Author

Can't figure out why the tests are failing, would appreciate if anyone can point me in the right direction?

@tico88612
Copy link
Member

/retest-failed

@tico88612
Copy link
Member

Hmmm, this is awkward. Cri-o seems to have changed its binary name at a specific time, and the CI didn't find the corresponding file.

You could refer to #10820 to make the change.

@philipsabri
Copy link
Author

Required tests passed. However, I'm not entirely sure about the non-required test related to CRI-O in this job but I'm looking into it.

@tico88612
Copy link
Member

@ant31 @VannTen How do we fix the Kubespray CI - molecule_cri-o job? (CRITICAL Idempotence test failed because of the following tasks......)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipsabri, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@yankay
Copy link
Member

yankay commented Sep 20, 2024

HI @VannTen @tico88612 @mzaian
Would you please help to review it again. :-)

@tico88612
Copy link
Member

tico88612 commented Sep 20, 2024 •
edited
Loading

@yankay, I would like to know the impact of a failure of the Idempotence test, which has not occurred in the past, although it is marked as a allow_failure.
(Kubespray CI - molecule_cri-o)

@yankay
Copy link
Member

yankay commented Sep 20, 2024

@yankay, I would like to know the impact of a failure of the Idempotence test, which has not occurred in the past, although it is marked as a allow_failure. (Kubespray CI - molecule_cri-o)

Thanks @tico88612

I have not noticed the CI fail. :-)

@yankay yankay removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
yankay
yankay reviewed Sep 20, 2024
View reviewed changes
roles/kubespray-defaults/defaults/main/checksums.yml
@@ -73,6 +81,7 @@ crio_archive_checksums:
# Kubernetes versions above Kubespray's current target version are untested and should be used with caution.
kubelet_checksums:
arm:
v1.31.0: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @philipsabri

v1.31.1 is missed

roles/kubespray-defaults/defaults/main/checksums.yml
@@ -291,6 +314,7 @@ kubectl_checksums:
v1.28.0: 7a9dcb4c75b33b9dac497c1a756b1f12c7c63f86fc0f321452360fbe1a79ce0f
kubeadm_checksums:
arm:
v1.31.0: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @philipsabri

v1.31.1 is missed

@yankay
Copy link
Member

yankay commented Sep 20, 2024 •
edited
Loading

From the release note https://github.com/cri-o/cri-o/releases/tag/v1.31.0 , the cri-o using crun as the default runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay left review comments

@mzaian mzaian Awaiting requested review from mzaian

@tico88612 tico88612 Awaiting requested review from tico88612

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.31 Support
5 participants
@philipsabri @k8s-ci-robot @tico88612 @mzaian @yankay