Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filestore NFSv4 support #1032

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Filestore NFSv4 support #1032

merged 1 commit into from
Jan 8, 2025

Conversation

riteshghorse
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Adds support for Filestore NFSv4

Which issue(s) this PR fixes:

Fixes #1000

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default protocol type for Filestore instances is NFSv3. To create NFSv4 Filestore instances, specify a `protocol` parameter in storage class with value `NFS_V4_1`.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @riteshghorse. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Jan 3, 2025 •
edited
Loading

R: @eipi-one @tyuchn

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2025
@tyuchn
Copy link
Contributor

tyuchn commented Jan 6, 2025

/lgtm

Could you please squash the commits into a single commit?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@tyuchn
Copy link
Contributor

tyuchn commented Jan 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@riteshghorse
Copy link
Contributor Author

/lgtm

Could you please squash the commits into a single commit?

Done, thanks! Forgot to squash earlier.

@riteshghorse
Copy link
Contributor Author

/retest-required

1 similar comment
@riteshghorse
Copy link
Contributor Author

/retest-required

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Jan 7, 2025 •
edited
Loading

@tyuchn, squashed to single commit, tests are passing now

@tyuchn
Copy link
Contributor

tyuchn commented Jan 8, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: riteshghorse, tyuchn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6c974a4 into kubernetes-sigs:master Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannawang0221 dannawang0221 Awaiting requested review from dannawang0221

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

Assignees

@tyuchn tyuchn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NFSv4 support in Filestore CSI Driver
3 participants
@riteshghorse @k8s-ci-robot @tyuchn