-
Notifications
You must be signed in to change notification settings - Fork 205
Standardize plugins.TypedName field name from 'tn' to 'typedName' #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Standardize plugins.TypedName field name from 'tn' to 'typedName' #1918
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Welcome @rohithnarasimha! |
|
Hi @rohithnarasimha. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rohithnarasimha thanks, looks good. /ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, rohithnarasimha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Change LoraAffinityScorer to use typedName - Change SLOAwareRouter to use typedName - Update test mocks: mockAdmissionPlugin, testResponseReceived, testResponseStreaming, testResponseComplete, mockDataSource - Improves consistency across all plugin implementations
0c37742 to
7ad8bab
Compare
|
New changes are detected. LGTM label has been removed. |
|
@rohithnarasimha: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
@nirrozenbaum |
There are separate issues:
|
|
This looks great, TY! |
Fixes #1910
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR standardizes the variable naming for
plugins.TypedNamefields across the codebase. Previously, bothtnandtypedNamewere used inconsistently. This change adoptstypedNameas the standard variable name for better code readability and consistency.Changes include:
Which issue(s) this PR fixes:
Fixes #1910
Does this PR introduce a user-facing change?: