Skip to content

Conversation

@rohithnarasimha
Copy link

  • Change LoraAffinityScorer to use typedName
  • Change SLOAwareRouter to use typedName
  • Update test mocks: mockAdmissionPlugin, testResponseReceived, testResponseStreaming, testResponseComplete, mockDataSource
  • Improves consistency across all plugin implementations

Fixes #1910

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR standardizes the variable naming for plugins.TypedName fields across the codebase. Previously, both tn and typedName were used inconsistently. This change adopts typedName as the standard variable name for better code readability and consistency.

Changes include:

  • Change LoraAffinityScorer to use typedName
  • Change SLOAwareRouter to use typedName
  • Update test mocks: mockAdmissionPlugin, testResponseReceived, testResponseStreaming, testResponseComplete, mockDataSource
  • Improves consistency across all plugin implementations

Which issue(s) this PR fixes:
Fixes #1910

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 1, 2025
@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7ad8bab
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/692d8ac8817d0b00082925c0
😎 Deploy Preview https://deploy-preview-1918--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2025

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @rohithnarasimha!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @rohithnarasimha. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 1, 2025
@nirrozenbaum
Copy link
Contributor

@rohithnarasimha thanks, looks good.
can you just sign your commits and fix the invalid commit message?

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, rohithnarasimha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
- Change LoraAffinityScorer to use typedName
- Change SLOAwareRouter to use typedName
- Update test mocks: mockAdmissionPlugin, testResponseReceived, testResponseStreaming, testResponseComplete, mockDataSource
- Improves consistency across all plugin implementations
@rohithnarasimha rohithnarasimha force-pushed the fix-typedname-standardization branch from 0c37742 to 7ad8bab Compare December 1, 2025 12:32
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

@rohithnarasimha: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rohithnarasimha
Copy link
Author

/retest-required

@rohithnarasimha
Copy link
Author

@nirrozenbaum
I tried to remove cncf-cla = no but signing the document but still not updated
tried multiple times signing
can you please help on this

@elevran
Copy link
Contributor

elevran commented Dec 1, 2025

I tried to remove cncf-cla = no but signing the document but still not updated
tried multiple times signing
can you please help on this

There are separate issues:

  1. missing CLA. Instructions in above comment. You need to sign (i.e., online acceptance) the CLA.
  2. need signed commits. See instructions in the official GH docs.

@kfswain
Copy link
Collaborator

kfswain commented Dec 1, 2025

This looks great, TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize the use of plugins.TypedName as key

6 participants