-
Notifications
You must be signed in to change notification settings - Fork 204
Add e2e test for multiport InferencePool enhancement #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RyanRosario The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @RyanRosario. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hey @danehans and @nirrozenbaum , my first PR is ready for review. |
|
/ok-to-test Thanks @RyanRosario. seems like your PR needs a rebase. additionally - please pay attention that your commits are not verified and if the PR is ready for review it would be good to remove the |
|
/retest |
|
Thank you for your patience! The failing test seems to be related to issue 1872. Can we continue with review or should 1872 be resolved first? |
failing test isn't blocking the review but it is blocking the merge. |
…e-extension into mpece-2
|
/hold cancel All initial feedback regarding rebase, tests, and global configuration changes have been compleed. |
What type of PR is this?
kind/cleanup
What this PR does / why we need it:
Adds an E2E test for multi-port enhancement. Currently verifyTrafficRouting is implemented, verifyMetrics to follow.
Which issue(s) this PR fixes:
Fixes #1768
Does this PR introduce a user-facing change?:
NONE