Updates from review comments

Signed-off-by: Shmuel Kallner <[email protected]>

Author: shmuelk

pkg/epp/backend/metrics/pod_metrics.go

@@ -25,7 +25,6 @@ import (
 
 	"github.com/go-logr/logr"
 
-	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datalayer"
 	logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
 )
@@ -35,7 +34,7 @@ const (
 )
 
 type podMetrics struct {
-	pod      atomic.Pointer[backend.Pod]
+	metadata atomic.Pointer[datalayer.EndpointMetadata]
 	metrics  atomic.Pointer[MetricsState]
 	pmc      PodMetricsClient
 	ds       datalayer.PoolInfo
@@ -49,23 +48,23 @@ type podMetrics struct {
 }
 
 type PodMetricsClient interface {
-	FetchMetrics(ctx context.Context, pod *backend.Pod, existing *MetricsState) (*MetricsState, error)
+	FetchMetrics(ctx context.Context, pod *datalayer.EndpointMetadata, existing *MetricsState) (*MetricsState, error)
 }
 
 func (pm *podMetrics) String() string {
 	return fmt.Sprintf("Pod: %v; Metrics: %v", pm.GetMetadata(), pm.GetMetrics())
 }
 
-func (pm *podMetrics) GetMetadata() *backend.Pod {
-	return pm.pod.Load()
+func (pm *podMetrics) GetMetadata() *datalayer.EndpointMetadata {
+	return pm.metadata.Load()
 }
 
 func (pm *podMetrics) GetMetrics() *MetricsState {
 	return pm.metrics.Load()
 }
 
 func (pm *podMetrics) UpdateMetadata(pod *datalayer.EndpointMetadata) {
-	pm.pod.Store(pod)
+	pm.metadata.Store(pod)
 }
 
 // start starts a goroutine exactly once to periodically update metrics. The goroutine will be

pkg/epp/backend/metrics/types.go

@@ -52,17 +52,17 @@ type PodMetricsFactory struct {
 	refreshMetricsInterval time.Duration
 }
 
-func (f *PodMetricsFactory) NewEndpoint(parentCtx context.Context, pod *datalayer.EndpointMetadata, ds datalayer.PoolInfo) PodMetrics {
+func (f *PodMetricsFactory) NewEndpoint(parentCtx context.Context, metadata *datalayer.EndpointMetadata, ds datalayer.PoolInfo) datalayer.Endpoint {
 	pm := &podMetrics{
 		pmc:       f.pmc,
 		ds:        ds,
 		interval:  f.refreshMetricsInterval,
 		startOnce: sync.Once{},
 		stopOnce:  sync.Once{},
 		done:      make(chan struct{}),
-		logger:    log.FromContext(parentCtx).WithValues("pod", pod.NamespacedName),
+		logger:    log.FromContext(parentCtx).WithValues("endpoint", metadata.NamespacedName),
 	}
-	pm.pod.Store(pod)
+	pm.metadata.Store(metadata)
 	pm.metrics.Store(NewMetricsState())
 
 	pm.startRefreshLoop(parentCtx)