Verify environment variables in e2e test #73
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
|
||
| kubectl wait --for=condition=Ready -n gpu-test4 pod/pod0 --timeout=120s | ||
| kubectl wait --for=condition=Ready -n gpu-test4 pod/pod1 --timeout=120s | ||
| gpu_test_4=$(kubectl get pods -n gpu-test4 | grep -c 'Running') | ||
| if [ $gpu_test_4 != 2 ]; then | ||
| echo "gpu_test_4 $gpu_test_4 failed to match against 1 expected pods" | ||
| echo "gpu_test_4 $gpu_test_4 failed to match against 2 expected pods" |
There was a problem hiding this comment.
FYI I did sneak in this typo fix also.
|
@nojnhuh this is definitely an improvement, thanks. Do you have a feel for the effort required to actually test the expected behaviour as called out in the README? |
Do you mean checking at least as far as whether certain containers have the same or different GPUs allocated based on the environment variables defined in each container? And that the correct TimeSlicing/SpacePartitioning parameters are set? I could definitely do that, but it might get a little messy in a bash script. |
I pushed these changes in a new commit which I plan to squash if we're good with those changes. /hold |
k8s-ci-robot
added
do-not-merge/hold
| @@ -35,6 +72,36 @@ if [ $gpu_test_1 != 2 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| gpu_test1_pod0_ctr0_logs=$(kubectl logs -n gpu-test1 pod0 -c ctr0) | |||
There was a problem hiding this comment.
I'm very open to suggestions for ways to make this less of a copy-paste nightmare.
|
@elezar This should be ready for another review, PTAL. |
k8s-ci-robot
added
the
approved
|
Squashed commits, didn't make any more changes in the process like the diff shows. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elezar, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Forgot to remove the hold here once I squashed. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm Based on #73 (review). |
k8s-ci-robot
added
the
lgtm
This change adds new steps to the e2e test to verify that each container in each pod contains logs showing the presence of any
GPU_DEVICE_*environment variables. I checked that this at least catches where the CDI config is not setup properly, but didn't try all of the other possible failure modes here.Fixes #57