make test fails with `make: *** [Makefile:73: test] Error 1`

[valdar]

Running make test on my environment results in:

15:37 $ make test
cd tools/setup-envtest && go test ./...
?   	sigs.k8s.io/controller-runtime/tools/setup-envtest	[no test files]
?   	sigs.k8s.io/controller-runtime/tools/setup-envtest/remote	[no test files]
ok  	sigs.k8s.io/controller-runtime/tools/setup-envtest/env	(cached)
ok  	sigs.k8s.io/controller-runtime/tools/setup-envtest/store	(cached)
ok  	sigs.k8s.io/controller-runtime/tools/setup-envtest/versions	(cached)
ok  	sigs.k8s.io/controller-runtime/tools/setup-envtest/workflows	(cached)
TRACE=1 ./hack/check-everything.sh
++ go mod edit -json
++ MODULES_ENABLED=0
++ MOD_OPT=
++ MODULES_OPT=
++ [[ -n '' ]]
++ NO_COLOR=
++ '[' -z '' ']'
++ header=''
++ reset=''
+ tmp_root=/tmp
+ kb_root_dir=/tmp/kubebuilder
++ make go-version
+ export 'GOTOOLCHAIN=gomake[1]: Entering directory '\''/home/valdar/projects/communityProjects/controller-runtime'\''
1.23.0
make[1]: Leaving directory '\''/home/valdar/projects/communityProjects/controller-runtime'\'''
+ GOTOOLCHAIN='gomake[1]: Entering directory '\''/home/valdar/projects/communityProjects/controller-runtime'\''
1.23.0
make[1]: Leaving directory '\''/home/valdar/projects/communityProjects/controller-runtime'\'''
+ ./hack/verify.sh
++ go mod edit -json
make: *** [Makefile:73: test] Error 1

I recon that the error is caused by the GOTOOLCHAIN being wrongly evaluated, in fact if I add the --silent option to these make invocations:

• controller-runtime/hack/check-everything.sh

  Line 27 in 6e9496d

  export GOTOOLCHAIN="go$(make go-version)"

• controller-runtime/hack/apidiff.sh

  Line 26 in 6e9496d

  export GOTOOLCHAIN="go$(make go-version)"

everything seems to work as expected.

[sbueringer]

Feel free to open a PR

[alvaroaleman]

Fixed in #3125