Fix tests

Author: dmvolod

cmd/clusterctl/cmd/plugin_test.go

@@ -37,6 +37,7 @@ const (
 )
 
 func Test_plugin(t *testing.T) {
+	g := NewWithT(t)
 	tt := []struct {
 		name     string
 		command  string
@@ -53,33 +54,33 @@ func Test_plugin(t *testing.T) {
 		},
 	}
 
+	tmpDir := os.TempDir()
+	defer os.Remove(tmpDir)
+
+	pluginPath := filepath.Join(tmpDir, "clusterctl-foo")
+	path := os.Getenv("PATH")
+	g.Expect(os.WriteFile(pluginPath, []byte(pluginCode), 0755)).To(Succeed()) //nolint:gosec
+
 	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			g := NewWithT(t)
-			stdout, _, err := runForkTest("TestExecutePlugin", fmt.Sprintf("%s=%s", pluginCommandEnvVar, tc.command))
+			stdout, _, err := runForkTest("TestExecutePlugin", fmt.Sprintf("%s=%s", pluginCommandEnvVar, tc.command), fmt.Sprintf("PATH=%s:%s", tmpDir, path))
 			g.Expect(err).NotTo(HaveOccurred())
 			g.Expect(stdout).To(ContainSubstring(tc.expected))
 		})
 	}
 }
 
 func TestExecutePlugin(t *testing.T) {
-	g := NewWithT(t)
 	if goutils.DefaultString(os.Getenv(forkEnvVar), "false") == strconv.FormatBool(false) {
 		t.Skip("FORK environment variable isn't set. Skipping test")
 	}
 
-	tmpDir := t.TempDir()
-	path := filepath.Join(tmpDir, "clusterctl-foo")
-	g.Expect(os.WriteFile(path, []byte(pluginCode), 0755)).To(Succeed()) //nolint:gosec
-	g.Expect(os.Setenv("PATH", fmt.Sprintf("%s:%s", os.Getenv("PATH"), tmpDir))).ToNot(HaveOccurred())
-
 	os.Args = append(baseArgs, os.Getenv(pluginCommandEnvVar))
 	Execute()
 }
 
-const pluginCode = `
-#!/bin/bash
+var pluginCode = `#!/bin/bash
 
 # optional argument handling
 if [[ "$1" == "version" ]]
@@ -91,9 +92,10 @@ fi
 echo "I am a plugin named clusterctl-foo"
 `
 
-func runForkTest(testName string, option string) (string, string, error) {
-	cmd := exec.Command(os.Args[0], fmt.Sprintf("-test.run=%v", testName)) //nolint:gosec
-	cmd.Env = append(os.Environ(), fmt.Sprintf("%s=%v", forkEnvVar, true), option)
+func runForkTest(testName string, options ...string) (string, string, error) {
+	cmd := exec.Command(os.Args[0], "-test.run", testName) //nolint:gosec
+	cmd.Env = append(os.Environ(), fmt.Sprintf("%s=%v", forkEnvVar, true))
+	cmd.Env = append(cmd.Env, options...)
 
 	var stdoutB, stderrB bytes.Buffer
 	cmd.Stdout = &stdoutB