fixup! ec2: enable primary IPv6 on ENI for EC2 instances

tthvo · tthvo · commit 4701b617dbf3 · 2025-10-22T15:33:25.000-07:00
Addressing reviews
diff --git a/pkg/cloud/services/ec2/instances.go b/pkg/cloud/services/ec2/instances.go
@@ -1325,6 +1325,9 @@ func getInstanceCPUOptionsRequest(cpuOptions infrav1.CPUOptions) *types.CpuOptio
 	return request
 }
 
+// shouldEnablePrimaryIpv6 determines whether to enable a primary IPv6 address for an instance.
+// It returns true if both the VPC has IPv6 enabled and the instance's subnet has an IPv6 CIDR block.
+// This is required when registering instances by ID to IPv6 target groups.
 func (s *Service) shouldEnablePrimaryIpv6(i *infrav1.Instance) (bool, error) {
 	var enablePrimaryIpv6 bool
 

Original file line number	Diff line number	Diff line change
`@@ -1325,6 +1325,9 @@ func getInstanceCPUOptionsRequest(cpuOptions infrav1.CPUOptions) *types.CpuOptio`
`1325`	`1325`	`return request`
`1326`	`1326`	`}`
`1327`	`1327`
	`1328`	`+// shouldEnablePrimaryIpv6 determines whether to enable a primary IPv6 address for an instance.`
	`1329`	`+// It returns true if both the VPC has IPv6 enabled and the instance's subnet has an IPv6 CIDR block.`
	`1330`	`+// This is required when registering instances by ID to IPv6 target groups.`
`1328`	`1331`	`func (s Service) shouldEnablePrimaryIpv6(i infrav1.Instance) (bool, error) {`
`1329`	`1332`	`var enablePrimaryIpv6 bool`
`1330`	`1333`