enabled commentstart linter and addressed findings

Author: v47

.golangci-kal.yml

@@ -25,7 +25,7 @@ linters:
               #- "nobools" # Bools do not evolve over time, should use enums instead.
               #- "nofloats" # Ensure floats are not used.
               #- "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
-              # - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
+              - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
               - "statussubresource" # All root objects that have a `status` field should have a status subresource.
 
             # Linters below this line are disabled, pending conversation on how and when to enable them.
@@ -45,11 +45,11 @@ linters:
           #   pointerPolicy: Warn | SuggestFix # Defaults to `SuggestFix`. We want our required fields to not be pointers.
 
 exclusions:
-    generated: strict
-    paths:
-      - zz_generated.*\.go$
-      - ".*_test.go"  # Exclude test files.
-    rules:
+  generated: strict
+  paths:
+    - zz_generated.*\.go$
+    - ".*_test.go" # Exclude test files.
+  rules:
     # KAL should only run on API folders.
     - path-except: "api//*"
       linters:

controlplane/eks/api/v1beta1/types.go

@@ -223,7 +223,7 @@ type OIDCIdentityProviderConfig struct {
 	// This is also known as audience. The ID for the client application that makes
 	// authentication requests to the OpenID identity provider.
 	// +kubebuilder:validation:Required
-	ClientID string `json:"clientId,omitempty"`
+	ClientID string `json:"clientId"`
 
 	// The JWT claim that the provider uses to return your groups.
 	// +optional
@@ -239,7 +239,7 @@ type OIDCIdentityProviderConfig struct {
 	//
 	// IdentityProviderConfigName is a required field
 	// +kubebuilder:validation:Required
-	IdentityProviderConfigName string `json:"identityProviderConfigName,omitempty"`
+	IdentityProviderConfigName string `json:"identityProviderConfigName"`
 
 	// The URL of the OpenID identity provider that allows the API server to discover
 	// public signing keys for verifying tokens. The URL must begin with https://
@@ -250,7 +250,7 @@ type OIDCIdentityProviderConfig struct {
 	// and must be publicly accessible over the internet.
 	//
 	// +kubebuilder:validation:Required
-	IssuerURL string `json:"issuerUrl,omitempty"`
+	IssuerURL string `json:"issuerUrl"`
 
 	// The key value pairs that describe required claims in the identity token.
 	// If set, each claim is verified to be present in the token with a matching

controlplane/eks/api/v1beta2/types.go

@@ -227,7 +227,7 @@ type OIDCIdentityProviderConfig struct {
 	// This is also known as audience. The ID for the client application that makes
 	// authentication requests to the OpenID identity provider.
 	// +kubebuilder:validation:Required
-	ClientID string `json:"clientId,omitempty"`
+	ClientID string `json:"clientId"`
 
 	// The JWT claim that the provider uses to return your groups.
 	// +optional
@@ -243,7 +243,7 @@ type OIDCIdentityProviderConfig struct {
 	//
 	// IdentityProviderConfigName is a required field
 	// +kubebuilder:validation:Required
-	IdentityProviderConfigName string `json:"identityProviderConfigName,omitempty"`
+	IdentityProviderConfigName string `json:"identityProviderConfigName"`
 
 	// The URL of the OpenID identity provider that allows the API server to discover
 	// public signing keys for verifying tokens. The URL must begin with https://
@@ -254,7 +254,7 @@ type OIDCIdentityProviderConfig struct {
 	// and must be publicly accessible over the internet.
 	//
 	// +kubebuilder:validation:Required
-	IssuerURL string `json:"issuerUrl,omitempty"`
+	IssuerURL string `json:"issuerUrl"`
 
 	// The key value pairs that describe required claims in the identity token.
 	// If set, each claim is verified to be present in the token with a matching

exp/api/v1beta1/types.go

@@ -53,7 +53,7 @@ type EBS struct {
 type BlockDeviceMapping struct {
 	// The device name exposed to the EC2 instance (for example, /dev/sdh or xvdh).
 	// +kubebuilder:validation:Required
-	DeviceName string `json:"deviceName,omitempty"`
+	DeviceName string `json:"deviceName"`
 
 	// You can specify either VirtualName or Ebs, but not both.
 	// +optional

exp/api/v1beta2/types.go

@@ -52,7 +52,7 @@ type EBS struct {
 type BlockDeviceMapping struct {
 	// The device name exposed to the EC2 instance (for example, /dev/sdh or xvdh).
 	// +kubebuilder:validation:Required
-	DeviceName string `json:"deviceName,omitempty"`
+	DeviceName string `json:"deviceName"`
 
 	// You can specify either VirtualName or Ebs, but not both.
 	// +optional