Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eipName (Name tag on eip) #2912

Open
Roxyrob opened this issue Dec 7, 2022 · 5 comments
Open

eipName (Name tag on eip) #2912

Roxyrob opened this issue Dec 7, 2022 · 5 comments
Assignees
@77-more
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Roxyrob
Copy link

Roxyrob commented Dec 7, 2022

Add support for eipName along with subnetName
AWS Load Balancer Controller support subnetName (Name tag on subnet) Annotations - subnets.

It will be useful to add support for eipName (Name tag on eip) also so configuration can gain a little more abstraction from AWS resources static IDs.
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Dec 7, 2022

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 7, 2022
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Dec 7, 2022 •
edited
Loading

similar to name of subnet, users need to ensure they configure unique names for EIP, and controller will error out if it found multiple EIP for same name.

And to be backwards-compatible, name shouldn't starts with eip-xxx, as it will be treated as EIP's ID.

@kishorj kishorj added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 9, 2022
@Sajiyah-Salat
Copy link

I understood the issue. I am finding diffculties in knowing what and where to change? let me know.

@cooleditphoto
Copy link

cooleditphoto commented Apr 27, 2023 •
edited
Loading

Just checked the annotations.md, there is no mention for eid- only service.beta.kubernetes.io/aws-load-balancer-eip-allocations: eipalloc-xyz, eipalloc-zzz, should I make name tag available for eid-allocations?

@77-more
Copy link

77-more commented Jul 24, 2023 •
edited
Loading

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@77-more 77-more

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@cooleditphoto @kishorj @k8s-ci-robot @Roxyrob @M00nF1sh @77-more @Sajiyah-Salat