Skip to content

Commit 682e779

Browse files
committed
Fix concurrent_test
1 parent 4d711b1 commit 682e779

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

pkg/server/server_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,10 +527,10 @@ func TestServerProxyConnectionMismatch(t *testing.T) {
527527
agentConn.EXPECT().Send(dialReq).Return(nil),
528528
agentConn.EXPECT().Send(data).Return(nil),
529529
)
530-
agentConn.EXPECT().Send(closeReqPkt(firstConnectID)).Return(nil)
531530
agentConn.EXPECT().Send(closeReqPkt(secondConnectID)).Return(nil)
532-
frontendConn.EXPECT().Send(closeRspPkt(firstConnectID, "mismatched connection IDs")).Return(nil)
531+
agentConn.EXPECT().Send(closeReqPkt(firstConnectID)).Return(nil)
533532
frontendConn.EXPECT().Send(closeRspPkt(secondConnectID, "mismatched connection IDs")).Return(nil)
533+
frontendConn.EXPECT().Send(closeRspPkt(firstConnectID, "mismatched connection IDs")).Return(nil)
534534
})
535535
}
536536

tests/concurrent_test.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,17 @@ func TestProxy_ConcurrencyGRPC(t *testing.T) {
4747
clientset := runAgent(proxy.agent, stopCh)
4848
waitForConnectedServerCount(t, 1, clientset)
4949

50-
// run test client
51-
tunnel, err := client.CreateSingleUseGrpcTunnel(ctx, proxy.front, grpc.WithInsecure())
52-
if err != nil {
53-
t.Fatal(err)
54-
}
55-
5650
var wg sync.WaitGroup
5751
verify := func() {
5852
defer wg.Done()
5953

54+
// run test client
55+
tunnel, err := client.CreateSingleUseGrpcTunnel(ctx, proxy.front, grpc.WithInsecure())
56+
if err != nil {
57+
t.Error(err)
58+
return
59+
}
60+
6061
c := &http.Client{
6162
Transport: &http.Transport{
6263
DialContext: tunnel.DialContext,
@@ -66,11 +67,13 @@ func TestProxy_ConcurrencyGRPC(t *testing.T) {
6667
r, err := c.Get(server.URL)
6768
if err != nil {
6869
t.Error(err)
70+
return
6971
}
7072

7173
data, err := ioutil.ReadAll(r.Body)
7274
if err != nil {
7375
t.Error(err)
76+
return
7477
}
7578
defer r.Body.Close()
7679

0 commit comments

Comments
 (0)