Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Dashboard] USE Method / Node(Windows) wrong queries for multiple choices variable (instance) #980

Open
4 tasks done
mkozikowsk opened this issue Oct 9, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed keepalive Use to prevent automatic closing

Comments

@mkozikowsk
Copy link

What happened?

Queries expect the single value for instance varaible:
For example query from the CPU Utilisation panel:
node:windows_node_cpu_utilisation:avg1m{cluster="$cluster", instance="$instance"}
image

Grafana automatically constructs the value1|...|valueN regexp for the $instance variable so the query should look like this:

node:windows_node_cpu_utilisation:avg1m{cluster="$cluster", instance=~"$instance"}

=~: Select labels that regex-match the provided string

image

Please provide any helpful snippets.

No response

What parts of the codebase are affected?

Dashboards

I agree to the following terms:

  • I agree to follow this project's Code of Conduct.
  • I have filled out all the required information above to the best of my ability.
  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have confirmed this bug exists in the default branch of the repository, as of the latest commit at the time of submission.
@skl skl added bug Something isn't working good first issue Good for newcomers labels Oct 9, 2024
@skl
Copy link
Collaborator

skl commented Oct 9, 2024

Thanks for raising @mkozikowsk! I see 16 matches for instance=" in dashboards/windows.libsonnet, which means there are a bunch of panels expecting only a single instance value.

Seems to me that either the instance dashboard variable needs multi-select disabling or all of these panels should be updated to handle multiple instances. If the latter, the queries need to be checked as some aggregations probably need labels adding (e.g. cluster and/or instance).

@skl skl added the help wanted Extra attention is needed label Oct 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
@skl skl reopened this Nov 19, 2024
@skl skl added keepalive Use to prevent automatic closing and removed stale labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed keepalive Use to prevent automatic closing
Projects
None yet
Development

No branches or pull requests

2 participants