Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irate is bad #679

Open
bboreham opened this issue Oct 18, 2021 · 3 comments
Open

irate is bad #679

bboreham opened this issue Oct 18, 2021 · 3 comments
Assignees
Labels
keepalive Use to prevent automatic closing

Comments

@bboreham
Copy link

#619 was a mistake.

irate() uses only the last two samples in a range, completely discarding all the other samples.
Discarding data is bad in observability, on principle.

Supposedly the benefit is to "see in finer detail". But only a portion of the data is seen in detail, the rest is discarded.
Bad.

@bboreham
Copy link
Author

See also #670

Copy link

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 12, 2024
@skl skl added the keepalive Use to prevent automatic closing label Oct 14, 2024
@skl skl self-assigned this Oct 14, 2024
@skl skl removed the stale label Oct 14, 2024
@bboreham
Copy link
Author

Still bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Use to prevent automatic closing
Projects
None yet
Development

No branches or pull requests

2 participants