-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1PodReadinessGate().conditionType only accepts preset enums in v15.0.0 #2192
Comments
https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.23/api/openapi-spec/swagger.json it seems that the openapi-spec on 1.23 release branch is broken, in the past it's just a plain string type, but since 1.23 it became an enum. will send a fix to that branch. thanks for reporting this. |
UPDATE: see the bug report at kubernetes/kubernetes#105057 (comment), the fix is kubernetes/kubernetes#105057 (comment) kubernetes/kubernetes#108740 |
this will be fixed by #2212 |
published 15.0.1, the new release should be available in the central registry w/i 48 hrs. /close |
@yue9944882: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Describe the bug
conditionType
has been changed to enumV1PodReadinessGate.ConditionTypeEnum
in v15.0.0 which prevents from using custom checks.In previous versions it was a String which allowed to set the name of the check directly, without it anyone using a custom readiness check is forced to stay on v14.x.
Client Version
v15.0.0
Kubernetes Version
e.g.
1.19.3
Java Version
Java 11
To Reproduce
This is no longer valid.
Expected behavior
An alternative to be able custom gates should be provided, maybe using something different than an enum or having another setter method.
KubeConfig
n/a
Server (please complete the following information):
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: