migrate to record (#1665)

* migrate to record

* chore: update project files and clean up unused references

* refactor: convert classes to records and simplify constructors for IntOrString, ResourceQuantity, and V1Patch

* fix: define IsExternalInit to resolve CS0518 error in IntOrString

* refactor: change IntOrString and ResourceQuantity from records to structs, update implicit conversions, and simplify null checks

* refactor: add JsonPropertyName attribute to Value property in IntOrString struct

* refactor: simplify V1Patch constructor and improve argument validation

* refactor: remove unnecessary CultureInfo parameter in ToInt method

* Update src/KubernetesClient/Models/ResourceQuantity.cs

Co-authored-by: Copilot <[email protected]>

* Update src/KubernetesClient/Models/IntOrString.cs

Co-authored-by: Copilot <[email protected]>

* Revert "Update src/KubernetesClient/Models/ResourceQuantity.cs"

This reverts commit 62b20a6.

* refactor: remove commented-out formatting check and simplify build command

* refactor: remove IValidate.cs from project references in Aot and Classic

---------

Co-authored-by: Copilot <[email protected]>

Author: tg123

.github/workflows/buildtest.yaml

@@ -17,12 +17,8 @@ jobs:
           dotnet-version: |
            8.0.x
            9.0.x
-      # - name: Check Format
-      #   # don't check formatting on Windows b/c of CRLF issues.
-      #   if: matrix.os == 'ubuntu-latest'
-      #   run: dotnet format --severity error --verify-no-changes --exclude ./src/KubernetesClient/generated/
       - name: Build
-        run: dotnet build --configuration Release -v detailed
+        run: dotnet build --configuration Release 
       - name: Test
         run: dotnet test --configuration Release --collect:"Code Coverage;Format=Cobertura" --logger trx --results-directory TestResults --settings CodeCoverage.runsettings --no-build
       - name: Upload coverage to Codecov

examples/csrApproval/Program.cs

@@ -67,7 +67,15 @@ string GenerateCertificate(string name)
 
 var replace = new List<V1CertificateSigningRequestCondition>
 {
-    new ("True", "Approved", DateTime.UtcNow, DateTime.UtcNow, "This certificate was approved by k8s client", "Approve"),
+    new V1CertificateSigningRequestCondition
+    {
+        Type = "Approved",
+        Status = "True",
+        Reason = "Approve",
+        Message = "This certificate was approved by k8s client",
+        LastUpdateTime = DateTime.UtcNow,
+        LastTransitionTime = DateTime.UtcNow,
+    },
 };
 readCert.Status.Conditions = replace;
 

examples/customResource/cResource.cs

@@ -19,13 +19,13 @@ public override string ToString()
         }
     }
 
-    public class CResourceSpec
+    public record CResourceSpec
     {
         [JsonPropertyName("cityName")]
         public string CityName { get; set; }
     }
 
-    public class CResourceStatus : V1Status
+    public record CResourceStatus : V1Status
     {
         [JsonPropertyName("temperature")]
         public string Temperature { get; set; }

examples/resize/Program.cs

@@ -23,7 +23,7 @@
                 {
                     Requests = new Dictionary<string, ResourceQuantity>()
                     {
-                        ["cpu"] = new ResourceQuantity("100m"),
+                        ["cpu"] = "100m",
                     },
                 },
             },

src/KubernetesClient.Aot/KubernetesClient.Aot.csproj

@@ -25,15 +25,13 @@
     <Compile Include="..\KubernetesClient\Models\IMetadata.cs" />
     <Compile Include="..\KubernetesClient\Models\IntOrStringJsonConverter.cs" />
     <Compile Include="..\KubernetesClient\Models\IntOrStringYamlConverter.cs" />
-    <Compile Include="..\KubernetesClient\Models\IntstrIntOrString.cs" />
+    <Compile Include="..\KubernetesClient\Models\IntOrString.cs" />
     <Compile Include="..\KubernetesClient\Models\ISpec.cs" />
     <Compile Include="..\KubernetesClient\Models\IStatus.cs" />
-    <Compile Include="..\KubernetesClient\IValidate.cs" />
     <Compile Include="..\KubernetesClient\Models\KubernetesEntityAttribute.cs" />
     <Compile Include="..\KubernetesClient\Models\KubernetesList.cs" />
     <Compile Include="..\KubernetesClient\KubernetesObject.cs" />
     <Compile Include="..\KubernetesClient\Models\ModelExtensions.cs" />
-    <Compile Include="..\KubernetesClient\Models\ModelVersionConverter.cs" />
     <Compile Include="..\KubernetesClient\Models\NodeMetrics.cs" />
     <Compile Include="..\KubernetesClient\Models\NodeMetricsList.cs" />
     <Compile Include="..\KubernetesClient\Models\PodMetrics.cs" />

src/KubernetesClient.Classic/IsExternalInit.cs

@@ -0,0 +1,5 @@
+// IntOrString.cs(7,36): error CS0518: Predefined type 'System.Runtime.CompilerServices.IsExternalInit' is not defined or imported
+namespace System.Runtime.CompilerServices
+{
+    internal static class IsExternalInit { }
+}

src/KubernetesClient.Classic/KubernetesClient.Classic.csproj

@@ -27,17 +27,15 @@
     <Compile Include="..\KubernetesClient\Models\IMetadata.cs" />
     <Compile Include="..\KubernetesClient\Models\IntOrStringJsonConverter.cs" />
     <Compile Include="..\KubernetesClient\Models\IntOrStringYamlConverter.cs" />
-    <Compile Include="..\KubernetesClient\Models\IntstrIntOrString.cs" />
+    <Compile Include="..\KubernetesClient\Models\IntOrString.cs" />
     <Compile Include="..\KubernetesClient\Models\ISpec.cs" />
     <Compile Include="..\KubernetesClient\Models\IStatus.cs" />
-    <Compile Include="..\KubernetesClient\IValidate.cs" />
     <Compile Include="..\KubernetesClient\Models\KubernetesEntityAttribute.cs" />
     <Compile Include="..\KubernetesClient\KubernetesJson.cs" />
     <Compile Include="..\KubernetesClient\Models\KubernetesList.cs" />
     <Compile Include="..\KubernetesClient\KubernetesObject.cs" />
     <Compile Include="..\KubernetesClient\KubernetesYaml.cs" />
     <Compile Include="..\KubernetesClient\Models\ModelExtensions.cs" />
-    <Compile Include="..\KubernetesClient\Models\ModelVersionConverter.cs" />
     <Compile Include="..\KubernetesClient\Models\NodeMetrics.cs" />
     <Compile Include="..\KubernetesClient\Models\NodeMetricsList.cs" />
     <Compile Include="..\KubernetesClient\Models\PodMetrics.cs" />

src/KubernetesClient/IValidate.cs

@@ -0,0 +1,38 @@
+namespace k8s.Models
+{
+    [JsonConverter(typeof(IntOrStringJsonConverter))]
+    public struct IntOrString
+    {
+        public string? Value { get; private init; }
+
+        public static implicit operator IntOrString(int v)
+        {
+            return Convert.ToString(v);
+        }
+
+        public static implicit operator IntOrString(long v)
+        {
+            return Convert.ToString(v);
+        }
+
+        public static implicit operator string(IntOrString v)
+        {
+            return v.Value;
+        }
+
+        public static implicit operator IntOrString(string v)
+        {
+            return new IntOrString { Value = v };
+        }
+
+        public override string ToString()
+        {
+            return Value;
+        }
+
+        public int ToInt()
+        {
+            return int.Parse(Value);
+        }
+    }
+}

src/KubernetesClient/Models/IntOrString.cs

@@ -1,8 +1,8 @@
 namespace k8s.Models
 {
-    internal sealed class IntOrStringJsonConverter : JsonConverter<IntstrIntOrString>
+    internal sealed class IntOrStringJsonConverter : JsonConverter<IntOrString>
     {
-        public override IntstrIntOrString Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+        public override IntOrString Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             switch (reader.TokenType)
             {
@@ -17,14 +17,14 @@ public override IntstrIntOrString Read(ref Utf8JsonReader reader, Type typeToCon
             throw new NotSupportedException();
         }
 
-        public override void Write(Utf8JsonWriter writer, IntstrIntOrString value, JsonSerializerOptions options)
+        public override void Write(Utf8JsonWriter writer, IntOrString value, JsonSerializerOptions options)
         {
             if (writer == null)
             {
                 throw new ArgumentNullException(nameof(writer));
             }
 
-            var s = value?.Value;
+            var s = value.Value;
 
             if (long.TryParse(s, out var intv))
             {