Skip to content

Commit f05220d

Browse files
committed
Addressing feedback
Signed-off-by: Fiona Waters <[email protected]>
1 parent c92f777 commit f05220d

File tree

19 files changed

+2530
-1299
lines changed

19 files changed

+2530
-1299
lines changed

README.md

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -73,38 +73,24 @@ print("\n".join(TrainerClient().get_job_logs(name=job_id)))
7373

7474
## Local Development
7575

76-
Kubeflow SDK provides first-class support for local development, allowing you to test and iterate on your models without needing a Kubernetes cluster.
76+
Kubeflow Trainer client supports local development without needing a Kubernetes cluster.
7777

78-
### Execution Backends
78+
### Available Backends
7979

80-
Choose the backend that fits your development workflow:
80+
- **KubernetesBackend** (default) - Production training on Kubernetes
81+
- **ContainerBackend** - Local development with Docker/Podman isolation
82+
- **LocalProcessBackend** - Quick prototyping with Python subprocesses
8183

82-
| Backend | Description | Use Case |
83-
|---------|-------------|----------|
84-
| **KubernetesBackend** | Run jobs on Kubernetes cluster | Production, multi-node distributed training |
85-
| **ContainerBackend** | Auto-detects Docker or Podman | Local development with container isolation |
86-
| **LocalProcessBackend** | Run as local Python subprocesses | Quick prototyping, debugging |
87-
88-
### Local Container Execution
89-
90-
The **ContainerBackend** automatically detects and uses either Docker or Podman:
91-
92-
```bash
93-
# Install with Docker support
94-
pip install kubeflow[docker]
95-
96-
# Or install with Podman support
97-
pip install kubeflow[podman]
98-
```
84+
**Quick Start:**
85+
Install container support: `pip install kubeflow[docker]` or `pip install kubeflow[podman]`
9986

10087
```python
10188
from kubeflow.trainer import TrainerClient, ContainerBackendConfig, CustomTrainer
10289

103-
# Auto-detects Docker or Podman
104-
config = ContainerBackendConfig()
105-
client = TrainerClient(backend_config=config)
90+
# Switch to local container execution
91+
client = TrainerClient(backend_config=ContainerBackendConfig())
10692

107-
# Your training runs in isolated containers
93+
# Your training runs locally in isolated containers
10894
job_id = client.train(trainer=CustomTrainer(func=train_fn))
10995
```
11096

kubeflow/trainer/__init__.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515

1616
# Import common types.
1717
from kubeflow.common.types import KubernetesBackendConfig
18-
# Import the Kubeflow Trainer client.
19-
from kubeflow.trainer.api.trainer_client import TrainerClient # noqa: F401
20-
from kubeflow.trainer.backends.container.types import ContainerBackendConfig
2118

2219
# Import the Kubeflow Trainer client.
2320
from kubeflow.trainer.api.trainer_client import TrainerClient
21+
from kubeflow.trainer.backends.container.types import (
22+
ContainerBackendConfig,
23+
TrainingRuntimeSource,
24+
)
2425
from kubeflow.trainer.backends.localprocess.types import LocalProcessBackendConfig
2526

2627
# Import the Kubeflow Trainer constants.
@@ -69,4 +70,5 @@
6970
"LocalProcessBackendConfig",
7071
"ContainerBackendConfig",
7172
"KubernetesBackendConfig",
73+
"TrainingRuntimeSource",
7274
]

kubeflow/trainer/api/trainer_client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import logging
1717
from typing import Optional, Union
1818

19+
from kubeflow.common.types import KubernetesBackendConfig
1920
from kubeflow.trainer.backends.container.backend import ContainerBackend
2021
from kubeflow.trainer.backends.container.types import ContainerBackendConfig
2122
from kubeflow.trainer.backends.kubernetes.backend import KubernetesBackend

kubeflow/trainer/backends/container/README.md

Lines changed: 0 additions & 162 deletions
This file was deleted.

kubeflow/trainer/backends/container/__init__.py

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)