fix: add --user when install python packages (#136)

Signed-off-by: Brian Gallagher <[email protected]>

Author: briangallagher

README.md

@@ -78,7 +78,7 @@ Kubeflow Trainer client supports local development without needing a Kubernetes
 ### Available Backends
 
 - **KubernetesBackend** (default) - Production training on Kubernetes
-- **ContainerBackend** - Local development with Docker/Podman isolation  
+- **ContainerBackend** - Local development with Docker/Podman isolation
 - **LocalProcessBackend** - Quick prototyping with Python subprocesses
 
 **Quick Start:**

kubeflow/trainer/backends/kubernetes/backend_test.py

@@ -217,6 +217,7 @@ def get_custom_trainer(
     """
     pip_command = [f"--index-url {pip_index_urls[0]}"]
     pip_command.extend([f"--extra-index-url {repo}" for repo in pip_index_urls[1:]])
+    pip_command.append("--user")
     pip_command = " ".join(pip_command)
 
     packages_command = " ".join(packages_to_install)

kubeflow/trainer/backends/kubernetes/utils.py

@@ -247,9 +247,8 @@ def get_script_for_python_packages(
     # first url will be the index-url.
     options = [f"--index-url {pip_index_urls[0]}"]
     options.extend(f"--extra-index-url {extra_index_url}" for extra_index_url in pip_index_urls[1:])
-    # For the OpenMPI, the packages must be installed for the mpiuser.
-    if is_mpi:
-        options.append("--user")
+    # Always install for the user to avoid permission issues across environments.
+    options.append("--user")
 
     header_script = textwrap.dedent(
         """

kubeflow/trainer/backends/kubernetes/utils_test.py

@@ -54,7 +54,7 @@ def _build_runtime() -> types.Runtime:
                 "--no-warn-script-location --index-url https://pypi.org/simple "
                 "--extra-index-url https://private.repo.com/simple "
                 "--extra-index-url https://internal.company.com/simple "
-                "torch numpy custom-package\n"
+                "--user torch numpy custom-package\n"
             ),
         ),
         TestCase(
@@ -71,7 +71,7 @@ def _build_runtime() -> types.Runtime:
                 "fi\n\n"
                 "PIP_DISABLE_PIP_VERSION_CHECK=1 python -m pip install --quiet "
                 "--no-warn-script-location --index-url https://pypi.org/simple "
-                "torch numpy custom-package\n"
+                "--user torch numpy custom-package\n"
             ),
         ),
         TestCase(
@@ -111,7 +111,7 @@ def _build_runtime() -> types.Runtime:
                 "fi\n\n"
                 "PIP_DISABLE_PIP_VERSION_CHECK=1 python -m pip install --quiet "
                 f"--no-warn-script-location --index-url "
-                f"{constants.DEFAULT_PIP_INDEX_URLS[0]} torch numpy\n"
+                f"{constants.DEFAULT_PIP_INDEX_URLS[0]} --user torch numpy\n"
             ),
         ),
     ],

kubeflow/trainer/backends/localprocess/constants.py

@@ -43,7 +43,7 @@
 # The exec script to embed training function into container command.
 DEPENDENCIES_SCRIPT = textwrap.dedent(
     """
-        PIP_DISABLE_PIP_VERSION_CHECK=1 pip install $QUIET \
+        PIP_DISABLE_PIP_VERSION_CHECK=1 pip install $QUIET --user \
     --no-warn-script-location $PIP_INDEX $PACKAGE_STR
     """
 )