Skip to content

Commit b6de5a7

Browse files
authored
chore: move pyproject.toml to root (#61)
* update testing info in CONTRIBUTING.md Signed-off-by: kramaranya <[email protected]> * move pyproject to the root dict Signed-off-by: kramaranya <[email protected]> * update CONTRIBUTING Signed-off-by: kramaranya <[email protected]> * remove python directory Signed-off-by: kramaranya <[email protected]> * Revert "remove python directory" This reverts commit 06a5bc4. Signed-off-by: kramaranya <[email protected]> * remove python directory Signed-off-by: kramaranya <[email protected]> * move version file to kubeflow dict Signed-off-by: kramaranya <[email protected]> --------- Signed-off-by: kramaranya <[email protected]>
1 parent d90dbce commit b6de5a7

File tree

19 files changed

+28
-21
lines changed

19 files changed

+28
-21
lines changed

.github/workflows/test-e2e.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ jobs:
3939
echo "Installing Papermill and Jupyter"
4040
pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5
4141
42-
echo "Installing Kubeflow SDK locally from ./python"
43-
# This path (./python) is relative to the *main* repository checkout (kubeflow/sdk)
44-
pip install ./python
42+
echo "Installing Kubeflow SDK locally"
43+
pip install .
4544
working-directory: . # Ensure pip runs from the SDK repo root
4645

4746
- name: Setup cluster

.pre-commit-config.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@ repos:
1010
rev: v0.4.4
1111
hooks:
1212
- id: ruff
13-
args: [--select=E,F,W]
1413
exclude: |
1514
(?x)^(
16-
python/kubeflow/trainer/__init__.py|
17-
python/kubeflow/trainer/api/__init__.py|
18-
python/kubeflow/trainer/models/.*|
15+
kubeflow/trainer/__init__.py|
16+
kubeflow/trainer/api/__init__.py|
17+
kubeflow/trainer/models/.*|
1918
)$

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ source .venv/bin/activate
2424

2525
Install dependencies in editable mode:
2626
```sh
27-
cd python
2827
pip install -e .
2928
```
3029

Makefile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ SHELL = /usr/bin/env bash -o pipefail
1919
.SHELLFLAGS = -ec
2020

2121
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
22-
23-
PY_DIR := $(PROJECT_DIR)/python
2422
VENV_DIR := $(PROJECT_DIR)/.venv
2523

2624
##@ General
@@ -54,8 +52,8 @@ ruff: ## Install Ruff
5452

5553
.PHONY: verify
5654
verify: uv uv-venv ruff ## install all required tools
57-
@cd $(PY_DIR) && uv lock --check
58-
@cd $(PY_DIR) && uvx ruff check --show-fixes
55+
@uv lock --check
56+
@uvx ruff check --show-fixes
5957

6058
.PHONY: uv-venv
6159
uv-venv:
@@ -69,8 +67,8 @@ uv-venv:
6967
# make test-python will produce html coverage by default. Run with `make test-python report=xml` to produce xml report.
7068
.PHONY: test-python
7169
test-python: uv-venv
72-
@uv pip install -e "$(PY_DIR)[dev]"
73-
@uv run coverage run --source=kubeflow.trainer.api.trainer_client,kubeflow.trainer.utils.utils -m pytest ./python/kubeflow/trainer/api/trainer_client_test.py
70+
@uv pip install -e ".[dev]"
71+
@uv run coverage run --source=kubeflow.trainer.api.trainer_client,kubeflow.trainer.utils.utils -m pytest ./kubeflow/trainer/api/trainer_client_test.py
7472
@uv run coverage report -m kubeflow/trainer/api/trainer_client.py kubeflow/trainer/utils/utils.py
7573
ifeq ($(report),xml)
7674
@uv run coverage xml

kubeflow/__init__.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Copyright 2025 The Kubeflow Authors.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
__version__ = "0.1.0"
File renamed without changes.

python/kubeflow/trainer/__init__.py renamed to kubeflow/trainer/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515

1616
from __future__ import absolute_import
1717

18-
__version__ = "0.1.0"
19-
2018
# Import the Kubeflow Trainer client.
2119
from kubeflow.trainer.api.trainer_client import TrainerClient # noqa: F401
2220

File renamed without changes.

0 commit comments

Comments
 (0)