Skip to content

Commit 60da2e6

Browse files
Marina Koushnirthesuperzapper
authored andcommitted
feat(ws): Upgrade Go to 1.24 - tensorboard-controller component
Signed-off-by: Marina Koushnir <[email protected]> Signed-off-by: Mathew Wicks <[email protected]>
1 parent 69b4734 commit 60da2e6

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

components/tensorboard-controller/Dockerfile

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,30 @@
33
#
44
# ${PATH_TO_KUBEFLOW/KUBEFLOW repo}/components
55
#
6-
FROM golang:1.17 as builder
6+
FROM golang:1.24 as builder
77

88
WORKDIR /workspace
99
# Copy the Go Modules manifests
10-
COPY tensorboard-controller /workspace/tensorboard-controller
10+
COPY tensorboard-controller/go.mod go.mod
11+
COPY tensorboard-controller/go.sum go.sum
1112
# cache deps before building and copying source so that we don't need to re-download as much
1213
# and so that source changes don't invalidate our downloaded layer
13-
RUN cd /workspace/tensorboard-controller && go mod download
14+
RUN go mod download
1415

15-
WORKDIR /workspace/tensorboard-controller
16+
# Copy the go source
17+
COPY tensorboard-controller/main.go main.go
18+
COPY tensorboard-controller/api/ api/
19+
COPY tensorboard-controller/controllers/ controllers/
20+
COPY tensorboard-controller/reconcilehelper/ reconcilehelper/
1621

1722
# Build
18-
RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -o manager main.go
23+
RUN CGO_ENABLED=0 GOOS=linux go build -a -o manager main.go
1924

2025
# Use distroless as minimal base image to package the manager binary
2126
# Refer to https://github.com/GoogleContainerTools/distroless for more details
2227
FROM gcr.io/distroless/static:nonroot
2328
WORKDIR /
24-
COPY --from=builder /workspace/tensorboard-controller/manager .
29+
COPY --from=builder /workspace/manager .
2530
USER 65532:65532
2631

2732
ENTRYPOINT ["/manager"]

components/tensorboard-controller/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/kubeflow/notebooks/components/tensorboard-controller
22

3-
go 1.17
3+
go 1.24
44

55
require (
66
github.com/go-logr/logr v1.2.0

0 commit comments

Comments
 (0)