Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller does not pick up a re-applied schedule. #21

Closed
chap-dr opened this issue Jun 7, 2020 · 2 comments · Fixed by #25
Closed

Controller does not pick up a re-applied schedule. #21

chap-dr opened this issue Jun 7, 2020 · 2 comments · Fixed by #25
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@chap-dr
Copy link

chap-dr commented Jun 7, 2020

Applied the example schedule, got an error saying the date was in the past (imo it should not matter as the repete was set to daily)

Updating with a future date, ran kubectl apply again without the controller picking up the change. removing and then adding the schedule made the controller pick up on the change.

@mbolt35
Copy link
Collaborator

mbolt35 commented Jun 8, 2020

I've added a new issue for ignoring date on repeat: #24

The other issue you're referring to is the way we handle failed (and completed) schedules. Whenever a schedule fails, we do not immediately delete the resource.

$ kubectl get tds
NAME               STATE            NEXT TURNDOWN   NEXT TURN UP
example-schedule   ScheduleFailed   <no value>      <no value>

Likewise, when a non-repeating schedule completes, the resource is not immediately deleted. These are mainly to show a status similar to a pod failing to locate an image. The resources will eventually be cleaned up (there's a 30 minute interval cleanup job that runs).

With the example we provide, example-schedule, if it fails and you try to re-apply, it will attempt to update the resource, which is not currently supported. We have a note in our docs regarding update via kubectl edit tds ... but not anything for example-schedule.

I agree that this is a bit annoying, and we plan on addressing the updating resource issue soon. In the mean time, I've updated the documentation surrounding the example-schedule.yaml interaction.

Thanks again for all your input!

@mbolt35 mbolt35 self-assigned this Jun 8, 2020
@mbolt35 mbolt35 added documentation Improvements or additions to documentation bug Something isn't working labels Jun 8, 2020
@mbolt35 mbolt35 pinned this issue Jun 8, 2020
@chap-dr
Copy link
Author

chap-dr commented Jun 8, 2020

No problem at all, great to see the quick response. 👍

@mbolt35 mbolt35 unpinned this issue Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants